Skip to content

fix(@angular/build): support NODE_EXTRA_CA_CERTS in SSR SSL plugin #32061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Dec 8, 2025
Merged

fix(@angular/build): support NODE_EXTRA_CA_CERTS in SSR SSL plugin #32061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions packages/angular/build/src/tools/vite/plugins/ssr-ssl-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
* found in the LICENSE file at https://angular.dev/license
*/

import { rootCertificates } from 'node:tls';
import { readFile } from 'node:fs/promises';
import { getCACertificates, rootCertificates, setDefaultCACertificates } from 'node:tls';
import type { Plugin } from 'vite';

export function createAngularServerSideSSLPlugin(): Plugin {
Expand Down Expand Up @@ -35,17 +36,30 @@ export function createAngularServerSideSSLPlugin(): Plugin {
httpServer.ALPNProtocols = ['http/1.1'];
}

// TODO(alanagius): Replace `undici` with `tls.setDefaultCACertificates` once we only support Node.js 22.18.0+ and 24.5.0+.
// See: https://nodejs.org/api/tls.html#tlssetdefaultcacertificatescerts
const { cert } = https;
const additionalCerts = Array.isArray(cert) ? cert : [cert];

// TODO(alanagius): Remove the `if` check once we only support Node.js 22.18.0+ and 24.5.0+.
if (getCACertificates && setDefaultCACertificates) {
const currentCerts = getCACertificates('default');
setDefaultCACertificates([...currentCerts, ...additionalCerts]);

return;
}

// TODO(alanagius): Remove the below and `undici` dependency once we only support Node.js 22.18.0+ and 24.5.0+.
const { getGlobalDispatcher, setGlobalDispatcher, Agent } = await import('undici');
const originalDispatcher = getGlobalDispatcher();
const { cert } = https;
const certificates = Array.isArray(cert) ? cert : [cert];
const ca = [...rootCertificates, ...additionalCerts];
const extraNodeCerts = process.env['NODE_EXTRA_CA_CERTS'];
if (extraNodeCerts) {
ca.push(await readFile(extraNodeCerts));
}

setGlobalDispatcher(
new Agent({
connect: {
ca: [...rootCertificates, ...certificates],
ca,
},
}),
);
Expand Down