-
Notifications
You must be signed in to change notification settings - Fork 178
Add local data types #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local data types #335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @weichenc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces support for additional fitness data types, specifically distance and calories expended, within the mobile recording API sample application. It enhances the user interface to allow selection of these new data types and updates the data handling logic to dynamically read and display the chosen fitness metrics.
Highlights
- Expanded Fitness Data Support: The application now supports TYPE_DISTANCE_DELTA and TYPE_CALORIES_EXPENDED in addition to the existing TYPE_STEP_COUNT_DELTA, allowing for a broader range of fitness tracking.
- Dynamic Data Type Selection UI: A new user interface element has been added to the HomeScreen that enables users to easily switch between viewing steps, distance, or calories data.
- Generalized Data Point Values: The fieldValue property in the DataPointData class has been refactored from an Int to a String, providing greater flexibility to represent various data types (e.g., decimal values for distance or calories) without type casting issues.
- Refactored Data Reading Logic: The RecordingAPIonMobileViewModel has been updated to dynamically subscribe to and read raw and aggregated fitness data based on the user's selected data type, improving the modularity and extensibility of the data retrieval process.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for TYPE_DISTANCE_DELTA and TYPE_CALORIES_EXPENDED data types, which is a great enhancement. The changes are generally well-implemented, with updates to the UI for data type selection and corresponding logic in the ViewModel. I've identified a couple of areas for improvement. There's significant code duplication in the ViewModel's data reading methods, which I recommend refactoring for better maintainability and robustness. I've also noted a minor issue with duplicate indices in the preview data for HomeScreen. Overall, good work on expanding the app's functionality.
...mple/recordingapionmobilesample/screen/recordingAPIonMobile/RecordingAPIonMobileViewModel.kt
Outdated
Show resolved
Hide resolved
...ileSample/app/src/main/java/com/example/recordingapionmobilesample/screen/home/HomeScreen.kt
Outdated
Show resolved
Hide resolved
2c10629 to
b68d865
Compare
Support
TYPE_DISTANCE_DELTAandTYPE_CALORIES_EXPENDED