Skip to content

2 Fixes: for modules.order containing *.o's, -watchdog #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jimc wants to merge 2 commits into
base: master
Choose a base branch
from
Open

2 Fixes: for modules.order containing *.o's, -watchdog #89

jimc wants to merge 2 commits into from

Conversation

@jimc
Copy link

@jimc jimc commented Oct 15, 2023

1st fixes virtme-run --kdir

jimc added 2 commits January 16, 2023 15:10
@jimc
fixup warnings about -watchdog
1ad9087 
In newer qemu -watchdog draws a warning and suggestion.  This change
seems to properly follow the advice and silence the thing.  Its about
3 months old, Ive been using it w/o issues.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
@jimc
fixup for modules.order containing *.o's
d056695 
As of: v6.1-rc6-24-gf65a486821cf
virtme-run --kdir $builddir is broken.
The cause is:

commit f65a486821cfd363833079b2a7b0769250ee21c9 (HEAD)
Author: Masahiro Yamada <masahiroy@kernel.org>
Date:   Sun Dec 11 22:04:07 2022 +0900

    kbuild: change module.order to list *.o instead of *.ko

    scripts/Makefile.build replaces the suffix .o with .ko, then
    scripts/Makefile.modpost calls the sed command to change .ko back
    to the original .o suffix.

    Instead of converting the suffixes back-and-forth, store the .o paths
    in modules.order, and replace it with .ko in 'make modules_install'.

    This avoids the unneeded sed command.

    Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
    Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>

virtme-prep-kdir-mod is expecting *.ko's, and is now getting *.o's.
It does the copying, but the *.o's arent loadable.

Fix with another shell-var and a parameter substitution on it.  This
will also work for kernels before the cited patch, which already have
the ko's

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
--
v1 - used sed, now uses bash parameter substitution wo forking.
@arighi
Copy link
Contributor

arighi commented Nov 17, 2023

@jimc all of this should be already fixed in virtme-ng (virtme is not maintained anymore and we moved the development to https://github.com/arighi/virtme-ng)

Can you give it a try with virtme-ng to confirm if everything works in your case? Thanks!

@jimc
Copy link
Author

jimc commented Nov 18, 2023 via email

@arighi
Copy link
Contributor

arighi commented Nov 18, 2023

@jimc awesome, thanks for testing! For the console output you need to pass --verbose now, that is a behavior change (kinda), but it doesn't really break anything and everything looks much cleaner/faster without showing the console output by default, so at the end I decided to switch to the "quiet" mode by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jimc @arighi