Skip to content

Conversation

@bomoko
Copy link
Contributor

@bomoko bomoko commented Dec 15, 2025

This pull request improves error handling and logging for job failures and exception scenarios involving PolydockAppInstance. The main focus is to ensure that errors are consistently logged both in the application logs and directly on the affected PolydockAppInstance for better traceability and debugging.

Enhanced error handling and logging:

  • Added a failed() method to the BaseJob class to log job failures, including error messages and stack traces, and to append error logs directly to the related PolydockAppInstance using the logLine method. The handler is designed to never throw exceptions itself, ensuring robust failure logging.
  • Updated exception handling in PolydockEngineFunctionCallerTrait so that when exceptions occur during app instance processing, errors are now also logged directly to the PolydockAppInstance using logLine, in addition to the existing logging. This is applied for status flow exceptions, process exceptions, and unknown exceptions, ensuring consistent and detailed error tracking on the instance.

Minor code style improvements:

  • Reformatted the constructor in BaseJob for consistency with code style guidelines.

@bomoko bomoko merged commit 89b61d8 into main Dec 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants