-
Notifications
You must be signed in to change notification settings - Fork 24
Connector Implementation & Inheritance: Anthropic Claude #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connector Implementation & Inheritance: Anthropic Claude #499
Conversation
…c Claude integration
…lternative model options
Adds links to the documentation for the Anthropic connector in the README, covering local machine, local container, and Azure deployments. Addresses the need to provide clear instructions for utilizing the new Anthropic connector. Related to aliencube#261
Updates the documentation to refer to Anthropic models instead of the specific Claude model, reflecting the broader range of models now supported. Relates to aliencube#261
…n and ensure proper function invocation
Related to : aliencube#342 * Add `MaxTokens` parameter to the Anthropic section in appsettings.json (Microsoft.Extensions.Configuration.Binder automatically converts string values to integers when binding configuration)
Relate to : aliencube#258 * Add`MaxTokens` property to AnthropicSettings
…lementation-Inheritance-AnthropicClaude
* update LanguageModelConnector to include Anthropic in unsupported list * will be re-enabled when Anthropic PR is merged
* mark all AnthropicConnectorTests as skipped to avoid CI failures while connector is unsupported
Related to : aliencube#259 * Add option ‘MaxTokens’ to AnthropicArgumentOptions and update parsing logic * Update ArgumentOptions.cs, AnthropicArgumentOptions.cs, AnthropicArgumentOptionsTests.cs
|
@sikutisa 죄송합니다.. 각 이슈별로 처리하다가 현재는 3까지 진행한 상태입니다!
그리고 현재 브랜치 병합하면서 문제생긴 부분이 있는데 해결하고 댓글 남겨놓겠습니다! |
sikutisa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
일단은 코드부터 보겠습니다. Connector는 작업이 다 안 된 것 같은데 맞나요?
test/OpenChat.PlaygroundApp.Tests/Components/Pages/Chat/ChatHeaderUITests.cs
Show resolved
Hide resolved
test/OpenChat.PlaygroundApp.Tests/Options/AnthropicArgumentOptionsTests.cs
Show resolved
Hide resolved
test/OpenChat.PlaygroundApp.Tests/Options/AnthropicArgumentOptionsTests.cs
Show resolved
Hide resolved
test/OpenChat.PlaygroundApp.Tests/Options/AnthropicArgumentOptionsTests.cs
Show resolved
Hide resolved
Validates the `MaxTokens` configuration setting in the `AnthropicConnector` to ensure it is present and a positive integer. This prevents runtime errors due to missing or invalid configurations. Also updates the Anthropic connector to use the `MaxTokens` setting from the configuration for `MaxOutputTokens` option.
Removes an unnecessary comment that restates the purpose of the 'MaxTokens' property.
Adds validation to ensure that the Anthropic connector settings for max tokens are correctly configured. Specifically, it checks for both the presence and validity of the `MaxTokens` setting, throwing an exception if it is missing or invalid.
Updates Anthropic argument options tests to use an integer type for max tokens configuration and environment variables. This change improves type safety and simplifies the configuration logic by removing the need for string parsing.
This reverts commit 4cbff1f.
* feat: add AnthropicConnector Related to: aliencube#261 * add bicep * add bicep
sikutisa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!
바쁘실텐데 죄송합니다 고생하셨습니다!! |
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
README updated?
The top-level readme for this repo contains a link to each sample in the repo. If you're adding a new sample did you update the readme?
How to Test
What to Check
Other Information about
AnthropicConnectorTests.cs생성/타입 관련
EnsureLanguageModelSettingsValid()
GetChatClientAsync()
CreateChatClientAsync()