Jesse ref #6
Open
Jesse ref #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
Just wondering why didn't you wrap the |
src/jesse_schema_validator.erl
Outdated
There was a problem hiding this comment.
Good catch. Forgot about it.
Author
|
About the Accumulator: IMHO, State components are changed rarely, while Accumulator could be changed on every iteration. Therefore, it doesn't fit into State. |
Author
What do you mean by that? |
tests pass after I add 'jesse:' in front of all references Got rid of 'jesse:' prefix; State record replaces three different arguments Added jesse_uri file Referencing URIs in a proper way Added testing basic tests up references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.