Update tests

Author: akd-io

packages/create-next-stack/package.json

@@ -57,6 +57,7 @@
     "test:large": "pnpm build && ts-node src/tests/e2e/test-manual.ts --debug --package-manager=pnpm --styling=emotion --react-hook-form --formik --prettier --formatting-pre-commit-hook --chakra --framer-motion --github-actions",
     "test:cna": "pnpm build && ts-node src/tests/e2e/test-live-cna.ts",
     "test:cns": "pnpm build && ts-node src/tests/e2e/test-live-cns.ts",
+    "test:raw": "pnpm build && ./bin/dev",
     "print:help": "pnpm build && ./bin/dev --help",
     "print:version": "pnpm build && ./bin/dev --version",
     "lint": "eslint --ext=.ts --config=.eslintrc --ignore-path=../../.prettierignore ."

packages/create-next-stack/src/main/commands/create-next-stack.ts

@@ -1,16 +1,12 @@
 import { Args, Command, Flags } from "@oclif/core"
-import chalk from "chalk"
-import endent from "endent"
 import { commandInstance } from "../command-instance"
 import {
-  CreateNextStackFlags,
   validateArgs,
   validateFlags,
   writablePackageManagerOptions,
   writableStylingOptions,
 } from "../create-next-stack-types"
 import { exitWithError } from "../helpers/exit-with-error"
-import { logInfo } from "../logging"
 import { performSetupSteps } from "../setup/setup"
 
 export default class CreateNextStack extends Command {
@@ -106,36 +102,16 @@ export default class CreateNextStack extends Command {
 
       if (flags.debug) process.env["DEBUG"] = "true"
 
-      if (calledWithoutFlags(flags)) {
-        logInfo()
-        logInfo(endent`
-          Create Next Stack does not support being run without flags.
-          
-              ${chalk.cyan`Please visit ${chalk.bold`https://create-next-stack.com/`} to pick your technologies.`}
-          
-              You can also use the --help flag for a list of available flags.
-        `)
-        logInfo()
-      } else {
-        if (!validateArgs(args)) {
-          process.exit(1) // This tells TypeScript that this block is unreachable. validateArgs(args) either throws or returns true.
-        }
-        if (!validateFlags(flags)) {
-          process.exit(1) // This tells TypeScript that this block is unreachable. validateFlags(flags) either throws or returns true.
-        }
-        await performSetupSteps({ args, flags })
+      if (!validateArgs(args)) {
+        process.exit(1) // This tells TypeScript that this block is unreachable. validateArgs(args) either throws or returns true.
       }
+      if (!validateFlags(flags)) {
+        process.exit(1) // This tells TypeScript that this block is unreachable. validateFlags(flags) either throws or returns true.
+      }
+
+      await performSetupSteps({ args, flags })
     } catch (error) {
       exitWithError(error)
     }
   }
 }
-
-const calledWithoutFlags = (flags: CreateNextStackFlags): boolean => {
-  const numOfAllFlags = Object.keys(flags).length
-
-  let numOfNonGeneralFlags = numOfAllFlags
-  if (flags.debug != null) numOfNonGeneralFlags--
-
-  return numOfNonGeneralFlags === 0
-}

packages/create-next-stack/src/main/helpers/exit-with-error.ts

@@ -5,8 +5,15 @@ import { inDebugMode } from "./in-debug-mode"
 export const exitWithError = (error: unknown): never => {
   if (error instanceof Errors.ExitError && error.oclif.exit === 0) {
     process.exit(0)
+  } else if (error instanceof Errors.CLIError) {
+    logError(error.message)
+    process.exit(1)
   } else if (error instanceof Error) {
-    if (error.stack != null) {
+    logError("An unknown error occurred.")
+    if (
+      (process.env.NODE_ENV === "development" || inDebugMode()) &&
+      error.stack != null
+    ) {
       logError(error.stack)
     }
   } else {

packages/create-next-stack/src/tests/e2e/test.ts

@@ -14,6 +14,7 @@ import { testTailwindCssAllFlags } from "./tests/tailwind-css/tailwind-css-all-f
 import { testTailwindCssOnly } from "./tests/tailwind-css/tailwind-css-only"
 import { testHelpFlag } from "./tests/test-help-flag"
 import { testInvalidInputs } from "./tests/test-invalid-inputs"
+import { testNoAppName } from "./tests/test-no-app-name"
 import { testNoFlags } from "./tests/test-no-flags"
 import { testNpm } from "./tests/test-npm"
 import { testVersionFlag } from "./tests/test-version-flag"
@@ -36,8 +37,9 @@ import { testYarn } from "./tests/test-yarn"
     // Invalid inputs
     await testInvalidInputs(createNextStackDir)
 
-    // No flags test
+    // Missing args and flags
     await testNoFlags(createNextStackDir)
+    await testNoAppName(createNextStackDir)
 
     // Package manager tests
     // pnpm is used in all other tests, so not tested here.

packages/create-next-stack/src/tests/e2e/tests/test-no-app-name.ts

@@ -0,0 +1,35 @@
+import { runCommand } from "../../../main/helpers/run-command"
+import { logTestMeta } from "../helpers/log-test-meta"
+import { minutesToMilliseconds } from "../helpers/minutes-to-milliseconds"
+import { prepareE2eTest } from "../helpers/prepare-e2e-test"
+
+export const testNoAppName = async (
+  createNextStackDir: string
+): Promise<void> => {
+  logTestMeta(testNoAppName.name, __filename)
+
+  const { pathToCLI, runDirectory } = await prepareE2eTest(createNextStackDir)
+
+  const argsVariants: string[][] = [
+    //
+    [],
+    ["--debug"],
+    ["--package-manager=pnpm"],
+  ]
+
+  for (const args of argsVariants) {
+    await runCommand(pathToCLI, args, {
+      timeout: minutesToMilliseconds(1),
+      cwd: runDirectory,
+    }).catch((error) => {
+      if (
+        !error.stderr.includes("Missing 1 required arg") ||
+        !error.stderr.includes("app_name")
+      ) {
+        throw new Error(
+          "Expected create-next-stack to error on missing app_name argument."
+        )
+      }
+    })
+  }
+}

packages/create-next-stack/src/tests/e2e/tests/test-no-flags.ts

@@ -11,24 +11,23 @@ export const testNoFlags = async (
   const { pathToCLI, runDirectory } = await prepareE2eTest(createNextStackDir)
 
   const argsVariants: string[][] = [
-    [],
-    ["--debug"],
+    //
     ["app-name"],
     ["app-name --debug"],
   ]
 
   for (const args of argsVariants) {
-    const result = await runCommand(pathToCLI, args, {
+    await runCommand(pathToCLI, args, {
       timeout: minutesToMilliseconds(1),
       cwd: runDirectory,
+    }).catch((error) => {
+      if (
+        !error.stderr.includes("Missing required flag package-manager") ||
+        !error.stderr.includes("Missing required flag styling")
+      ) {
+        console.log("throwing error")
+        throw new Error("Expected create-next-stack to error on missing flags.")
+      }
     })
-
-    if (
-      !result.stdout.includes(
-        "Please visit https://create-next-stack.com/ to pick your technologies."
-      )
-    ) {
-      throw new Error("Expected create-next-stack to post link to website.")
-    }
   }
 }