Fix build

Author: akd-io

packages/create-next-stack/src/main/commands/create-next-stack.ts

@@ -3,7 +3,6 @@ import chalk from "chalk"
 import endent from "endent"
 import { commandInstance } from "../command-instance"
 import {
-  CreateNextStackArgs,
   CreateNextStackFlags,
   validateArgs,
   validateFlags,
@@ -20,7 +19,7 @@ export default class CreateNextStack extends Command {
   static args = {
     app_name: Args.string({
       description: `The name of your app, optionally including a path prefix. Eg.: "my-app" or "path/to/my-app"`,
-      required: false,
+      required: true,
     }),
   }
 
@@ -40,6 +39,7 @@ export default class CreateNextStack extends Command {
 
     // Package manager:
     "package-manager": Flags.string({
+      required: true,
       options: writablePackageManagerOptions,
       description: "Sets the preferred package manager. (Required)",
     }),
@@ -51,6 +51,7 @@ export default class CreateNextStack extends Command {
 
     // Styling:
     styling: Flags.string({
+      required: true,
       options: writableStylingOptions,
       description: `Sets the preferred styling method. (Required) <styling-method> = ${writableStylingOptions.join(
         "|"
@@ -101,11 +102,7 @@ export default class CreateNextStack extends Command {
     commandInstance.set(this)
 
     try {
-      const { args: weaklyTypedArgs, flags: weaklyTypedFlags } =
-        await this.parse(CreateNextStack)
-
-      const args = weaklyTypedArgs as CreateNextStackArgs
-      const flags = weaklyTypedFlags as CreateNextStackFlags
+      const { args, flags } = await this.parse(CreateNextStack)
 
       if (flags.debug) process.env["DEBUG"] = "true"
 

packages/create-next-stack/src/main/create-next-stack-types.ts

@@ -1,6 +1,5 @@
 import { Config } from "@oclif/core"
 import CreateNextStack from "./commands/create-next-stack"
-import { UnknownObject } from "./helpers/is-unknown-object"
 import { validateProjectPathInput } from "./helpers/validate-project-path"
 import { Writable } from "./helpers/writable"
 
@@ -21,11 +20,8 @@ export type CreateNextStackParserOutput = ReturnType<
   typeof temporaryWrapperForTypeSafety
 >
 
-// Unvalidated Args and Flags types
-export type CreateNextStackArgs = UnknownObject // Change to ParserOutput["args"] if it becomes strongly typed in the future. (Currently a normal object with any-values.)
-export type CreateNextStackFlags = Partial<
-  Awaited<CreateNextStackParserOutput>["flags"]
-> // Change to CreateNextStackParserOutput["flags"] if it becomes strongly typed in the future. (Currently not a Partial.)
+export type CreateNextStackArgs = Awaited<CreateNextStackParserOutput>["args"]
+export type CreateNextStackFlags = Awaited<CreateNextStackParserOutput>["flags"]
 
 // Package manager flag:
 export const packageManagerOptions = ["pnpm", "yarn", "npm"] as const
@@ -48,22 +44,13 @@ export const writableStylingOptions = stylingOptions as Writable<
 >
 
 // Valid Args type and type guard
-export type ValidCreateNextStackArgs = CreateNextStackArgs & { appName: string }
 export const validateArgs = (
   args: CreateNextStackArgs
-): args is ValidCreateNextStackArgs => {
-  if (typeof args["appName"] !== "string") {
-    throw new TypeError(
-      'You are required to specify a name for your application. Read about the "appName" argument using --help.'
-    )
-  }
-
-  const appNameValidationResult = validateProjectPathInput(args["appName"])
-
+): args is CreateNextStackArgs => {
+  const appNameValidationResult = validateProjectPathInput(args.app_name)
   if (typeof appNameValidationResult === "string") {
     throw new TypeError("Invalid app name: " + appNameValidationResult)
   }
-
   return true
 }
 
@@ -76,16 +63,6 @@ export const validateFlags = (
   flags: CreateNextStackFlags
 ): flags is ValidCreateNextStackFlags => {
   // TODO: Define validator using zod.
-  if (typeof flags["package-manager"] !== "string") {
-    throw new Error(
-      'You are required to specify a package manager. Read about the "--package-manager" option using --help.'
-    )
-  }
-  if (typeof flags.styling !== "string") {
-    throw new Error(
-      'You are required to specify a styling method. Read about the "--styling" option using --help.'
-    )
-  }
   if (flags.chakra && flags.styling !== "emotion") {
     throw new Error(
       "Chakra UI (category: Component library, flag: --chakra) requires Emotion (category: Styling, flag: --styling=emotion)."
@@ -110,6 +87,6 @@ export const validateFlags = (
 }
 
 export type ValidCNSInputs = {
-  args: ValidCreateNextStackArgs
+  args: CreateNextStackArgs
   flags: ValidCreateNextStackFlags
 }

packages/create-next-stack/src/main/plugins/create-next-stack/add-content/pages/generate-index.ts

@@ -11,7 +11,7 @@ export const generateIndexPage = ({ args }: ValidCNSInputs): string => endent`
     return (
       <>
         <Head>
-          <title>${getProjectNameOfPath(args.appName)}</title>
+          <title>${getProjectNameOfPath(args.app_name)}</title>
           <meta name="description" content="Generated by Create Next Stack." />
         </Head>
         <LandingPageTemplate />

packages/create-next-stack/src/main/plugins/create-next-stack/add-content/templates/LandingPage/generate-LandingPageTemplate.ts

@@ -19,7 +19,7 @@ export const generateLandingPageTemplate = (inputs: ValidCNSInputs): string => {
     const LandingPageTemplate = () => {
       const onConfettiLoad = () => {
         const key = "create-next-stack-hasShownConfetti-${encodeURI(
-          getProjectNameOfPath(inputs.args.appName)
+          getProjectNameOfPath(inputs.args.app_name)
         )}";
         const hasShownConfetti = localStorage.getItem(key);
         if (hasShownConfetti != null) return;

packages/create-next-stack/src/main/plugins/create-next-stack/add-readme/generate-readme.ts

@@ -13,7 +13,7 @@ export const generateReadme = async (
   const runCommand = runCommandMap[flags["package-manager"]]
 
   return endent`
-    # ${getProjectNameOfPath(args.appName)}
+    # ${getProjectNameOfPath(args.app_name)}
 
     🎉 Congratulations, your project was successfully generated with [Create Next Stack](https://www.create-next-stack.com/)!
 

packages/create-next-stack/src/main/plugins/next.ts

@@ -5,7 +5,7 @@ import { makeDirectory, writeFile } from "../helpers/io"
 import { remove } from "../helpers/remove"
 import { runCommand } from "../helpers/run-command"
 import { logDebug } from "../logging"
-import { createPlugin, Package } from "../plugin"
+import { Package, createPlugin } from "../plugin"
 import { getNameVersionCombo } from "../setup/packages"
 import { generateNextConfig } from "./create-next-stack/add-next-config/generate-next-config"
 
@@ -62,18 +62,18 @@ export const nextPlugin = createPlugin({
 
       run: async ({ args, flags }) => {
         // Make sure directory exists to avoid error from create-next-app
-        await makeDirectory(args.appName)
+        await makeDirectory(args.app_name)
 
         logDebug(endent`
-          Directory created: ${args.appName}
+          Directory created: ${args.app_name}
     
           To open the project in vscode, run:
     
-              ${chalk.cyan(`code ${path.resolve(args.appName)}`)}
+              ${chalk.cyan(`code ${path.resolve(args.app_name)}`)}
         `)
 
         const createNextAppArgs = [
-          args.appName,
+          args.app_name,
           "--typescript",
           "--eslint",
           "--no-experimental-app",
@@ -122,8 +122,8 @@ export const nextPlugin = createPlugin({
         // Reset npm_config_user_agent
         process.env["npm_config_user_agent"] = oldNpmConfigUserAgent
 
-        logDebug("Changing directory to", args.appName)
-        process.chdir(args.appName)
+        logDebug("Changing directory to", args.app_name)
+        process.chdir(args.app_name)
       },
     },
     removeOfficialCNAContent: {

packages/create-next-stack/src/main/setup/print-final-messages.ts

@@ -14,14 +14,14 @@ export const printFinalMessages = ({ args, flags }: ValidCNSInputs): void => {
   logInfo("")
   logInfo(
     chalk.green(
-      `Successfully created project ${getProjectNameOfPath(args.appName)}!`
+      `Successfully created project ${getProjectNameOfPath(args.app_name)}!`
     )
   )
   logInfo("")
   logInfo("To get started, run:")
   logInfo("")
-  if (args.appName !== ".") {
-    logInfo(chalk.cyan(`    cd ${args.appName}`))
+  if (args.app_name !== ".") {
+    logInfo(chalk.cyan(`    cd ${args.app_name}`))
   }
   logInfo(chalk.cyan(`    ${runCommandMap[flags["package-manager"]]} dev`))
   logInfo("")