client: drop support for python 3.8 #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop support for Python 3.8. This change aligns with Python 3.8 reaching end-of-life and allows the codebase to use modern Python features and type annotations. - Update minimum Python version from 3.8 to 3.9 in project metadata and documentation - Update mypy, black, ruff configuration to target Python 3.9 - Update CI workflow to use Python 3.9 for linting and remove 3.8 from test matrix - Replace deprecated typing imports with collections.abc equivalents (Collection, Mapping, Sequence, Iterator, Container, Iterable)
Prime541
reviewed
Oct 31, 2025
Contributor
Prime541
left a comment
Prime541
left a comment
There was a problem hiding this comment.
Thanks for removing the support of Python 3.8, EOL on 2024-10-07
pyproject.toml
Outdated
| [tool.black] | ||
| line-length = 125 | ||
| target-version = ['py38', 'py39', 'py310', 'py311'] | ||
| target-version = ['py39', 'py310', 'py311'] |
Contributor
There was a problem hiding this comment.
Since this pyproject supports Python 3.14, shouldn't we also extend the target-version list?
Contributor
Author
There was a problem hiding this comment.
Those target-version additions required black upgrade, and I had other plans for black (replace with ruff). That's why, I didn't bother, but for the sake of completeness, I added those changes as well.
black, isort versions were upgraded to downstream build environment versions. - Upgrade black from 23.3.0 to >=24.4.2 (Python 3.14 support) - Upgrade isort from >=5.11.5 to >=6.1.0 (Python 3.14 support) - Upgrade mypy from >=1.0.1 to >=1.17.1 - Add Python 3.12, 3.13, and 3.14 to Black target versions
Prime541
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop support for Python 3.8. This change aligns with Python 3.8
reaching end-of-life and allows the codebase to use modern
Python features and type annotations.
and documentation
test matrix
(Collection, Mapping, Sequence, Iterator, Container, Iterable)
version.pyto ruff exclusion list (similar toflake8)