Skip to content

improve errors for playbook parsing #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
whotwagner merged 1 commit into from
Oct 29, 2025
Merged

improve errors for playbook parsing #179

whotwagner merged 1 commit into from
Oct 29, 2025

Conversation

@thorinaboenke
Copy link
Contributor

@thorinaboenke thorinaboenke commented Oct 29, 2025 •
edited
Loading

relates to issue #154

  • makes Command a discriminated Union (to reduce noise when type checking, otherwise pydantic checks all members of the union)
  • add concise error messages for the most common parsing errors, missing_field, literal_error and value_error (still keep logging the error traceback)
    Demo:
image

@whotwagner whotwagner merged commit 27434dd into ait-testbed:development Oct 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whotwagner whotwagner whotwagner approved these changes

@annaerdi annaerdi Awaiting requested review from annaerdi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thorinaboenke @whotwagner