Skip to content

Conversation

@ShenJunkun
Copy link

Description

This PR addresses #65 by replacing the rigid SandboxType enum with a string-based identifier. This change allows users to register custom sandbox types beyond the built-in options, supporting diverse scenarios like domain-specific images or custom security policies.

Changes

  • Replaced SandboxType enum with String in @RegisterSandbox and registry logic.
  • Defined SandboxType constants to maintain backward compatibility.
  • Updated the identification key to (userId, sessionId, sandboxType).

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my own code.
  • All new and existing tests passed.

@cla-assistant
Copy link

cla-assistant bot commented Dec 29, 2025

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Dec 29, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant