[WIP] feat(core): Redesign Session and StateModule API for type-safe state persistence #388

AlbumenJ · 2025-12-29T13:20:58Z

No description provided.

…persistence Change-Id: Ibce1f62ce38ac544b80433507bfe2c00ce30c469

Copilot

Pull request overview

This PR introduces a major redesign of the session and state management API to provide type-safe state persistence for AgentScope. The new API replaces string-based session identifiers with a SessionKey interface and introduces a State marker interface for persistable objects, enabling compile-time type safety and better incremental storage support.

Key changes:

New SessionKey/SimpleSessionKey and State interfaces for type-safe session and state management
New StateModule.saveTo()/loadFrom() methods replacing the legacy stateDict() API
StatePersistence configuration record allowing fine-grained control over which components are persisted
Toolkit no longer extends StateModuleBase; its activeGroups state is now managed by ReActAgent

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 21 comments.

Show a summary per file

File	Description
`State.java`	New marker interface for persistable state objects
`SessionKey.java`	New marker interface for session identifiers
`SimpleSessionKey.java`	Default string-based SessionKey implementation with validation
`StatePersistence.java`	Configuration record for controlling component state management
`AgentMetaState.java`	Record for agent metadata persistence
`ToolkitState.java`	Record for toolkit active groups persistence
`PlanNotebookState.java`	Record for plan state persistence
`StateModule.java`	Added new saveTo/loadFrom API, deprecated legacy methods
`Session.java`	Added type-safe save/get methods with SessionKey, deprecated string-based methods
`JsonSession.java`	Implemented new API with JSONL incremental storage for lists
`InMemorySession.java`	Implemented new API with in-memory storage (full replacement)
`Msg.java`	Now implements State interface
`ContentBlock.java`	Now implements State interface
`InMemoryMemory.java`	Implemented saveTo/loadFrom with new API
`PlanNotebook.java`	Implemented StateModule, added saveTo/loadFrom support
`Toolkit.java`	Removed StateModuleBase inheritance, added setActiveGroups method
`ReActAgent.java`	Added StatePersistence configuration and saveTo/loadFrom implementation
`SupervisorAgent.java`	Updated to reflect Toolkit no longer being a StateModule component
Test files	Comprehensive test coverage for new API across all components

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

agentscope-core/src/main/java/io/agentscope/core/tool/Toolkit.java

agentscope-core/src/main/java/io/agentscope/core/plan/PlanNotebook.java

agentscope-core/src/main/java/io/agentscope/core/session/JsonSession.java

agentscope-core/src/main/java/io/agentscope/core/memory/InMemoryMemory.java

agentscope-core/src/main/java/io/agentscope/core/plan/PlanNotebook.java

agentscope-core/src/main/java/io/agentscope/core/ReActAgent.java

agentscope-core/src/test/java/io/agentscope/core/state/SimpleSessionKeyTest.java

agentscope-core/src/test/java/io/agentscope/core/state/StateRecordsTest.java

…persistence Change-Id: I0ff5a9f563e7a7096db38278c64b76cf33a19abf

codecov · 2025-12-30T02:14:30Z

Codecov Report

❌ Patch coverage is 78.80539% with 110 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...n/java/io/agentscope/core/session/JsonSession.java	69.04%	21 Missing and 5 partials ⚠️
...io/agentscope/core/session/mysql/MysqlSession.java	79.79%	11 Missing and 9 partials ⚠️
...ntscope/core/session/redis/jedis/JedisSession.java	84.70%	8 Missing and 5 partials ⚠️
...ope/core/memory/autocontext/AutoContextMemory.java	0.00%	12 Missing ⚠️
...e/core/session/redis/redisson/RedissonSession.java	86.58%	8 Missing and 3 partials ⚠️
...va/io/agentscope/core/session/InMemorySession.java	85.71%	4 Missing and 2 partials ⚠️
...ava/io/agentscope/core/session/SessionManager.java	78.26%	4 Missing and 1 partial ⚠️
...ain/java/io/agentscope/core/state/StateModule.java	37.50%	5 Missing ⚠️
...io/agentscope/core/tool/subagent/SubAgentTool.java	0.00%	5 Missing ⚠️
...e/src/main/java/io/agentscope/core/ReActAgent.java	83.33%	0 Missing and 4 partials ⚠️
... and 1 more

📢 Thoughts on this report? Let us know!

Copilot

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

agentscope-core/src/main/java/io/agentscope/core/session/JsonSession.java

agentscope-core/src/main/java/io/agentscope/core/session/InMemorySession.java

agentscope-core/src/main/java/io/agentscope/core/memory/InMemoryMemory.java

agentscope-core/src/main/java/io/agentscope/core/plan/PlanNotebook.java

...sor-agent/src/main/java/io/agentscope/examples/bobatea/supervisor/agent/SupervisorAgent.java

…persistence Change-Id: I674b243d3a8080f05ae3004c540c36521de954c4

…persistence Change-Id: I66d3744dfe16b4874932d9803e7209a50c45a999

…persistence Change-Id: If97082b04df8cc643332f266ad3501dd47383466

Change-Id: Ia5df1edfd7bbd9293b50044731af9abddcac6075

Copilot

Pull request overview

Copilot reviewed 50 out of 50 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

docs/en/task/session.md

docs/zh/task/session.md

…persistence Change-Id: I5053d7e81bddaa0453809f55f8d76ac015aa6c75

…persistence Change-Id: Id263ec3145d934fc51b6926f0e87f2b85381d0d3

Copilot

Pull request overview

Copilot reviewed 53 out of 53 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-30T07:42:59Z

...xtensions-session-mysql/src/test/java/io/agentscope/core/session/mysql/MysqlSessionTest.java

+    void testSaveAndGetListState() throws SQLException {
        when(mockStatement.execute()).thenReturn(true);
        when(mockStatement.executeUpdate()).thenReturn(1);
+        when(mockStatement.executeQuery()).thenReturn(mockResultSet);


This ResultSet is not always closed on method exit.

Copilot · 2025-12-30T07:42:59Z

...xtensions-session-mysql/src/test/java/io/agentscope/core/session/mysql/MysqlSessionTest.java

+    void testGetNonExistentListState() throws SQLException {
        when(mockStatement.execute()).thenReturn(true);
-        when(mockStatement.executeUpdate()).thenReturn(1);
+        when(mockStatement.executeQuery()).thenReturn(mockResultSet);


This ResultSet is not always closed on method exit.

…persistence Change-Id: I7eed1f45bf8a0ba62214694c833cd52229bb16b1

…persistence Change-Id: Iff9e88c41e5807db3f2dfd3459d8ab16867dd2d6

Copilot

Pull request overview

Copilot reviewed 53 out of 53 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

feat(core): Redesign Session and StateModule API for type-safe state …

5b3a071

…persistence Change-Id: Ibce1f62ce38ac544b80433507bfe2c00ce30c469

AlbumenJ requested review from a team and Copilot December 29, 2025 13:20

AlbumenJ changed the title ~~feat(core): Redesign Session and StateModule API for type-safe state persistence~~ [WIP] feat(core): Redesign Session and StateModule API for type-safe state persistence Dec 29, 2025

Copilot started reviewing on behalf of AlbumenJ December 29, 2025 13:21 View session

Copilot AI reviewed Dec 29, 2025

View reviewed changes

feat(core): Redesign Session and StateModule API for type-safe state …

ae7e93e

…persistence Change-Id: I0ff5a9f563e7a7096db38278c64b76cf33a19abf

AlbumenJ requested a review from Copilot December 30, 2025 02:14

Copilot started reviewing on behalf of AlbumenJ December 30, 2025 02:15 View session

Copilot AI reviewed Dec 30, 2025

View reviewed changes

AlbumenJ added 4 commits December 30, 2025 10:31

feat(core): Redesign Session and StateModule API for type-safe state …

b7f7abb

…persistence Change-Id: I674b243d3a8080f05ae3004c540c36521de954c4

feat(core): Redesign Session and StateModule API for type-safe state …

29a6179

…persistence Change-Id: I66d3744dfe16b4874932d9803e7209a50c45a999

feat(core): Redesign Session and StateModule API for type-safe state …

2ea3aa1

…persistence Change-Id: If97082b04df8cc643332f266ad3501dd47383466

Merge branch 'refs/heads/main' into 1229-session

84f864b

Change-Id: Ia5df1edfd7bbd9293b50044731af9abddcac6075

AlbumenJ requested a review from Copilot December 30, 2025 03:55

Copilot started reviewing on behalf of AlbumenJ December 30, 2025 03:56 View session

Copilot AI reviewed Dec 30, 2025

View reviewed changes

docs/en/task/session.md Show resolved Hide resolved

docs/zh/task/session.md Show resolved Hide resolved

AlbumenJ added 2 commits December 30, 2025 14:46

feat(core): Redesign Session and StateModule API for type-safe state …

04e4fa1

…persistence Change-Id: I5053d7e81bddaa0453809f55f8d76ac015aa6c75

feat(core): Redesign Session and StateModule API for type-safe state …

bb4f47d

…persistence Change-Id: Id263ec3145d934fc51b6926f0e87f2b85381d0d3

AlbumenJ requested a review from Copilot December 30, 2025 07:37

Copilot started reviewing on behalf of AlbumenJ December 30, 2025 07:38 View session

Copilot AI reviewed Dec 30, 2025

View reviewed changes

AlbumenJ added 2 commits December 30, 2025 15:46

feat(core): Redesign Session and StateModule API for type-safe state …

5f8eab0

…persistence Change-Id: I7eed1f45bf8a0ba62214694c833cd52229bb16b1

feat(core): Redesign Session and StateModule API for type-safe state …

93672ff

…persistence Change-Id: Iff9e88c41e5807db3f2dfd3459d8ab16867dd2d6

AlbumenJ requested a review from Copilot December 30, 2025 08:25

Copilot started reviewing on behalf of AlbumenJ December 30, 2025 08:25 View session

Copilot AI reviewed Dec 30, 2025

View reviewed changes

[WIP] feat(core): Redesign Session and StateModule API for type-safe state persistence #388

Are you sure you want to change the base?

[WIP] feat(core): Redesign Session and StateModule API for type-safe state persistence #388

Uh oh!

Conversation

AlbumenJ commented Dec 29, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

codecov bot commented Dec 30, 2025 •

edited

Loading