Skip to content

Conversation

@guanxuc
Copy link
Contributor

@guanxuc guanxuc commented Dec 27, 2025

AgentScope-Java Version

1.0.5-SNAPSHOT

Description

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with mvn spotless:apply
  • All tests are passing (mvn test)
  • Javadoc comments are complete and follow project conventions
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

@guanxuc guanxuc requested a review from a team December 27, 2025 16:11
@guanxuc guanxuc marked this pull request as draft December 27, 2025 17:02
@guanxuc guanxuc marked this pull request as ready for review December 28, 2025 02:13
@codecov
Copy link

codecov bot commented Dec 28, 2025

Copy link
Collaborator

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are currently refactoring the OpenAIModel implementation and expect to merge it soon. I suggest basing your analysis and changes on #320. Once #320 is merged, you can proceed to complete this feature.

@guanxuc
Copy link
Contributor Author

guanxuc commented Dec 28, 2025

We are currently refactoring the OpenAIModel implementation and expect to merge it soon. I suggest basing your analysis and changes on #320. Once #320 is merged, you can proceed to complete this feature.

OK, thx for your quickly feedback, I'll update the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Default to including usage field in OpenAI API completions/chat responses

2 participants