fix: Graceful MCP server initialization failure handling #88
+206
−46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #87
When MCP servers fail to initialize (e.g., unavailable package, network issues, missing dependencies), the agent now gracefully degrades instead of failing entirely.
Problem
Previously, if any MCP server failed to initialize, the agent would fail to load with:
This was problematic when:
Solution
The agent now:
Changes
crates/aof-runtime/src/executor/runtime.rs:create_mcp_executor_from_confignow returnsOption<Arc<dyn ToolExecutor>>instead of errorCombinedToolExecutorto support both builtin and MCP toolsload_agent_from_configto handle MCP failures gracefullytest_mcp_executor_graceful_failuredocs/reference/agent-spec.md:Testing
Tested with non-existent MCP server - agent loads and responds successfully using Shell tool only.
Log output shows graceful degradation:
Checklist
🤖 Generated with Claude Code