Skip to content

Conversation

@sakib412
Copy link
Contributor

… Level

❓ Type of change

  • [x ] 🐞 Bug fix (a non-breaking change that fixes an issue)

📚 Description

update level type to suggest default Level

📝 Checklist

  • [ x] I have updated the documentation accordingly.

Copilot AI review requested due to automatic review settings December 15, 2025 10:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the TypeScript type definition for the level parameter in the file function to provide better IDE autocomplete suggestions while maintaining flexibility to accept any string value.

Key Changes

  • Updated the level parameter type from string | Level to (string & {}) | Level to enable IDE autocomplete for predefined Level values while still accepting custom string values

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@thetutlage
Copy link
Member

Can you please run npm run format and then push your code?

@sakib412
Copy link
Contributor Author

Can you please run npm run format and then push your code?

Done

@thetutlage thetutlage merged commit 835b706 into adonisjs:7.x Dec 20, 2025
4 checks passed
@thetutlage
Copy link
Member

Thanks 👍🏽

@sakib412 sakib412 deleted the patch-1 branch December 23, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants