Skip to content

Conversation

@purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented Dec 5, 2025

Description

Removing this value that we were propagating all the way to S3, the UI cannot resolve the user so this information is not required. Logs cover who deployed and when, so the data is there.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the auditUserId feature from the deploy command, as this user identifier cannot be displayed in the UI. The change eliminates unused functionality related to extracting and passing user IDs from JWT tokens during deployment operations.

Key changes:

  • Removed auditUserId extraction and passing from the deploy workflow
  • Removed getTokenData import from deploy command (function is no longer called)
  • Cleaned up related test cases that validated auditUserId behavior

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/commands/app/deploy.js Removed getTokenData import and eliminated code that extracted user_id from JWT tokens and passed it as auditUserId to deployment configuration
test/commands/app/deploy.test.js Removed five test cases validating auditUserId behavior with different token states (valid user_id, undefined, null, empty string, and null token data) and cleaned up associated mock setup
test/commands/lib/auth-helper.test.js Removed test case for successful JWT token decoding via getTokenData

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@sandeep-paliwal sandeep-paliwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some comments from Co-pilot to be resolved before merging.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@purplecabbage purplecabbage merged commit 8e557e5 into master Dec 5, 2025
17 checks passed
@purplecabbage purplecabbage deleted the ACNA-4207 branch December 5, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants