add studiolab_picoexpander #10737
Open
add studiolab_picoexpander #10737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…changes. Lines starting
Jerzeek
changed the title
dhalbert
requested changes
Dec 5, 2025
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Hi, this looks fine overall. I've made some naming change suggestions.
| // | ||
| // SPDX-License-Identifier: MIT | ||
|
|
||
| #define MICROPY_HW_BOARD_NAME "Pico Expander" |
Collaborator
There was a problem hiding this comment.
add your manufacturer name here, like "Studiolab Pico Expander" or however you capitalize and space it ("Studio Lab", "studiolab", etc.)
|
|
||
| #include "shared-bindings/board/__init__.h" | ||
|
|
||
| static const mp_rom_map_elem_t board_module_globals_table[] = { |
Collaborator
There was a problem hiding this comment.
In the pin list below, group pin aliases together, with blank lines in between, so it's easy to see which pins have which multiple names. You did this with some pins toward the end of the list. Put the preferred name first: that is the name that will be listed by dir(board). E.g.:
(I don't know which name you want to be the primary name: your choice.)
[blank line]
{ MP_ROM_QSTR(MP_QSTR_SDA), MP_ROM_PTR(&pin_GPIO4) },
{ MP_ROM_QSTR(MP_QSTR_GP4), MP_ROM_PTR(&pin_GPIO4) },
{ MP_ROM_QSTR(MP_QSTR_D4), MP_ROM_PTR(&pin_GPIO4) },
[blank line]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
We made an expander board for the Pico 2W, The Pico 2W is soldered on the board, and it has some peripherals permanently connected to the board so it made sense to make a custom board file for it.
It is part of a bigger project to learn the Industrial Design students at the Technical University of Delft to program, more info here: https://id-studiolab.github.io/Connected-Interaction-Kit/test/components/
I built the board, copied the UF2 file, tested the functionality, and all seems good!
Since our previous board utilized the ItsyBitsy M4, we aim to maintain backward compatibility with the D pins. Therefore, we have ensured that students can use both D as well as GP syntax, for example: D5 as well as GP5.
Let me know if anything is unclear.