Skip to content

Conversation

@2bndy5
Copy link
Contributor

@2bndy5 2bndy5 commented Dec 3, 2025

This removes the "Build Python package" step from the "Build CI" workflow in favor of reusing the build job in the release CI workflow. It adds triggers to the release CI for push and pull_request events that target the main branch. To be clear, publishing will only happen when a GitHub release is published (just like previous behavior).

I also removed some steps in the Build CI workflow that would only make sense if experimenting with GitHub Actions.

This patch uploads dists to PyPI using the trusted publisher setup in the PyPI project settings. (per #135 (review))

This removes the "Build Python package" step from the "Build CI" workflow in favor of reusing the build job in the release CI workflow. It adds triggers to the release CI for `push` and `pull_request` events that target the main branch. To be clear, publishing will only happen when a GitHub release is published (just like previous behavior).

I also removed some steps in the Build CI workflow that would only make sense if experimenting with GitHub Actions.

This patch uploads dists to PyPI using the trusted publisher setup in the PyPI project settings. (per adafruit#135 (review))
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit a21bf0f into adafruit:main Dec 4, 2025
3 checks passed
@2bndy5 2bndy5 deleted the questionable-ci-changes branch December 4, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants