Add more docs and fix linting

Author: mscosti

adafruit_esp32spi/adafruit_esp32spi.py

@@ -412,14 +412,24 @@ def wifi_set_entenable(self):
             raise RuntimeError("Failed to enable enterprise mode")
 
     def wifi_set_ap_network(self, ssid, channel):
-        """TODO Docs"""
+        """
+        Creates an Access point with SSID and Channel
+
+        :param ssid: the SSID of the created Access Point. Must be 8 or more characters
+        :param channel: channel of created Access Point (1 - 14).
+        """
         resp = self._send_command_get_response(_SET_AP_NET_CMD, [ssid, channel])
         if resp[0][0] != 1:
             raise RuntimeError("Failed to setup AP network")
 
     def wifi_set_ap_passphrase(self, ssid, passphrase, channel):
-        """TODO Docs"""
-        """ TODO: Why does this command refuse to work? creating AP w/out password works fine"""
+        """
+        Creates an Access point with SSID, passphrase, and Channel
+
+        :param ssid: the SSID of the created Access Point. Must be 8 or more characters
+        :param passphrase: the password of the created Access Point. Must be 8 or more characters.
+        :param channel: channel of created Access Point (1 - 14).
+        """
         resp = self._send_command_get_response(_SET_AP_PASSPHRASE_CMD, [ssid, passphrase, channel])
         if resp[0][0] != 1:
             raise RuntimeError("Failed to setup AP password")
@@ -497,7 +507,7 @@ def connect_AP(self, ssid, password): # pylint: disable=invalid-name
             raise RuntimeError("No such ssid", ssid)
         raise RuntimeError("Unknown error 0x%02X" % stat)
 
-    def create_AP(self, ssid, password, channel=b'\x01'):
+    def create_ap(self, ssid, password, channel=b'\x01'):
         """Create an access point with the given name and password."""
         if isinstance(ssid, str):
             ssid = bytes(ssid, 'utf-8')

adafruit_esp32spi/adafruit_esp32spi_wifimanager.py

@@ -97,20 +97,21 @@ def connect(self):
     def create_ap(self):
         """
         Attempt to initialize in Access Point (AP) mode.
+        Uses SSID and optional passphrase from the current settings
         Other WiFi devices will be able to connect to the created Access Point
         """
         failure_count = 0
         while not self._esp.ap_listening:
             try:
                 if self.debug:
                     print("Waiting for AP to be initialized...")
-                self.pixel_status((100,0,0))
-                if(self.password):
-                    self._esp.create_AP(bytes(self.ssid, 'utf-8'), bytes(self.password, 'utf-8'))
+                self.pixel_status((100, 0, 0))
+                if self.password:
+                    self._esp.create_ap(bytes(self.ssid, 'utf-8'), bytes(self.password, 'utf-8'))
                 else:
-                    self._esp.create_AP(bytes(self.ssid, 'utf-8'), None)
+                    self._esp.create_ap(bytes(self.ssid, 'utf-8'), None)
                 failure_count = 0
-                self.pixel_status((0,100,0))
+                self.pixel_status((0, 100, 0))
             except (ValueError, RuntimeError) as error:
                 print("Failed to create access point\n", error)
                 failure_count += 1