-
Notifications
You must be signed in to change notification settings - Fork 65
feat(deposit-tracking): parse mint and burn event on solana #2137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0xjorgen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions
src/utils/cctp.ts
Outdated
|
|
||
| async queryMintAndWithdrawEvents(fromSlot?: bigint, toSlot?: bigint) { | ||
| return await this.queryEvents( | ||
| "MintAndWithdraw" as any, // Maybe override queryEvents method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the correct thing here be to add MintAndWithdraw to SVMEventNames in the SDK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class is actually built for the SVM spoke contract. I am really just repurposing it's methods here since the event querying and unwrapping logic is the same as long as you initialize this with the correct program id and idl.
The best solution is probably to make changes to the original client in the sdk to infer event names based on the idl passed into its constructor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is removed anyway so no longer relevant f8e775f
src/utils/cctp.ts
Outdated
| return events.filter((event) => event.name === "DepositForBurn"); | ||
| } | ||
|
|
||
| async queryMintAndWithdrawEvents(fromSlot?: bigint, toSlot?: bigint) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you using this method anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I will remove it along with queryDepositForBurnEvents since those are not really viable options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove f8e775f
| let fillEventTxRef = ""; | ||
|
|
||
| if (!fillEvent) { | ||
| if (bridgeProvider === "cctp") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont uderstand why this is //todo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
|
Deployment failed with the following error: Learn More: https://vercel.link/3Fpeeb1 |
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
closes FE-217
Work done
CCTP (Sponsored)
CCTP (NOT Sponsored)