feat: output amount sim market order hypercore #2109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dohaki
requested review from
0xjorgen,
NikolasHaimerl,
amateima,
ashwinrava,
gsteenkamp89,
melisaguevara,
mrice32,
nicholaspai and
pxrl
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ashwinrava
approved these changes
Dec 16, 2025
Member
ashwinrava
left a comment
ashwinrava
left a comment
There was a problem hiding this comment.
Looks good!! Thanks for adding this. I will rebase on top of your commit and amend my PR. 👍
Comment on lines
+346
to
349
| const baseAvailable = ethers.utils.parseUnits( | ||
| Number(level.sz).toFixed(tokenIn.decimals), | ||
| tokenIn.decimals | ||
| ); |
Member
There was a problem hiding this comment.
I see in some places we use isBuyingBase to determine if we should use tokenIn.decimals vs tokenOut.decimals. Is it all the same in HyperCore or do we need that check?
Contributor
Author
There was a problem hiding this comment.
Yea, good point... I think I wrote this before I knew that every token on HyperCore has 8 decimals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to set a output amount for
simulateMarketOrdervia Hyperliquid. Useful for #2106