chore: port hardhat tests to foundry
#1219
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ihor Farion <ihor@umaproject.org>
Signed-off-by: Ihor Farion <ihor@umaproject.org>
Contributor
Author
|
This PR migrates the first of the tests under Let's merge it first to have a common base to use (like the fixture code) |
grasphoper
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
tbwebb22
reviewed
Jan 7, 2026
Comment on lines
58
to
62
| uint256 constant OFT_FEE_CAP = 1 ether; | ||
| uint256 constant L2_MAX_SUBMISSION_COST = 0.01 ether; | ||
| uint256 constant L2_GAS_PRICE = 5 gwei; | ||
| uint32 constant RELAY_MESSAGE_L2_GAS_LIMIT = 2_000_000; | ||
| uint32 constant RELAY_TOKENS_L2_GAS_LIMIT = 300_000; |
Contributor
There was a problem hiding this comment.
Should we just read these from the adapter contract rather than redeclaring them as constants here?
Contributor
Author
There was a problem hiding this comment.
Yeah good point. Should we add something like a claude agent to our GH workspace somehow so that it can address fixes like this? I'll do this manually, but just a thought for the future
Signed-off-by: Ihor Farion <ihor@umaproject.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ACX-4890