Skip to content

[cleanup] Remove StaticDataTable #10219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
driusan wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[cleanup] Remove StaticDataTable #10219

driusan wants to merge 1 commit into from

Conversation

@driusan
Copy link
Collaborator

@driusan driusan commented Dec 9, 2025

We have 2 components which are almost identical, StaticDataTable and DataTable.

This removes the (older) StaticDataTable and updates the references to be references to DataTable.

It also is imported by webpack everywhere it is used, so stop compiling it independently and including it in getJSDependencies.

@github-actions github-actions bot added Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: dqt PR or issue related to (old) dqt module Module: candidate_parameters PR or issue related to candidate_parameters module Module: electrophysiology_browser PR or issue related to electrophysiology_browser module Module: help_editor PR or issue related to help_editor module Module: imaging_uploader PR or issue related to imaging_uploader module Module: mri_violations PR or issue related to mri_violations module Module: publication PR or issue related to the publication module labels Dec 9, 2025
@driusan
Copy link
Collaborator Author

driusan commented Dec 9, 2025

(Sent as a draft to be sure it doesn't accidentally get merged before the release)

[cleanup] Remove StaticDataTable
82b56cb 
We have 2 components which are almost identical, StaticDataTable and DataTable.

This removes the (older) StaticDataTable and updates the references to be references
to DataTable.

It also is imported by webpack everywhere it is used, so stop compiling it independently
and including it in getJSDependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Module: candidate_parameters PR or issue related to candidate_parameters module Module: dqt PR or issue related to (old) dqt module Module: electrophysiology_browser PR or issue related to electrophysiology_browser module Module: help_editor PR or issue related to help_editor module Module: imaging_uploader PR or issue related to imaging_uploader module Module: mri_violations PR or issue related to mri_violations module Module: publication PR or issue related to the publication module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@driusan