Add all failures for a given test to the JUnit report #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were only ever parsing the first failure for a test and passing that to the JUnit representation. However, a test might contain multiple failures and this is fully supported by the JUnit spec. To fix the issue, we'll collect all failures from the XCResult file and pass them to the JUnit result a list. This will prevent us from losing important diagnostic information from the test result.
luispadron
approved these changes
Dec 16, 2025
jszumski
approved these changes
Dec 19, 2025
a7ex
approved these changes
Dec 19, 2025
Owner
a7ex
left a comment
a7ex
left a comment
There was a problem hiding this comment.
Thanks for sharing the improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were only ever parsing the first failure for a test and passing that to the JUnit representation. However, a test might contain multiple failures and this is fully supported by the JUnit spec.
To fix the issue, we'll collect all failures from the XCResult file and pass them to the JUnit result a list. This will prevent us from losing important diagnostic information from the test result.