Siren dgun missile salvo concept

[Stiofan-K]

Siren's missile always felt a little hard to control or use in a way that feels good.
It most often wastes it shot against a mobile target unless you pretarget a static and there is no way to prevent it from firing while keeping the main sonar gun active.
Rightclicking/Forcefiring a distant target makes it fall back onto its missile, and so the Siren will not approach. (Dante has this too with its missiles after using dgun)

So the idea was to make Sirens missile easier to use effectively by allowing manual fire of a salvo of its missiles and to try to remove those wrinkles in the controlscheme. Could also be an opportunity to push its missile more into a costal siege/support role too.

In this implementation it is in addition to the automatic launch, where the cooldown of the manual missile salvo prevents the automatic missile fire, so the effective dps stays roughly the same while the Siren doesnt punish inactivity too much.
The salvo of 4 is 1600 damage/2 Ravens, and could be comboed with the automatic missile for 2000 burst damage, though has 64s reload to keep the dps even.

It may be better to use a pure manual fire approach and remove the automatic missile, as rightclicking a target still makes Siren wait for its missile instead of approaching, though there may be a workaround for that too and let the automatic missile not respond to forcefire.
A pure manualfire would get around that, and maybe allow the missiles to be balanced around its antistructure capability.

Also curious to hear your peepes's input on it

Oh, also included is an adjustment to combat distance, since I observed that two Sirens on Amove toward eachother keep too much distance to use their Sonar weapons.

[Stiofan-K]

o.o"
I cant edit the PR without causing it to bump huh... (I hope comments are safe?)
This is more me poking around to try and figure things out anyways, it seemed like a very low stake thing to look at.
From what I can tell, the behavior of sticking at maximum weapon range of the longest range weapon on forcefire has no spring native workarounds in weapon or unitdefs.

Options to adjust that sort of behavior is dropping the automatic missile so there is no conflict, or I think a widget to workaround? Weapon customparams could be used let a unit define its main/combat weapon, which forcefire should bring into range.

Also the extradrawrange thats supposed to show the missile range seems to only draw for one siren if multiple are selected.