-
Notifications
You must be signed in to change notification settings - Fork 9
feat(compat): Prepare for Enhanced compatibility + several fixes #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Don't create release if no changes. - editorconfig: Limit to Lua and Python source files only. Stop reformatting YAML with tabs.
- Exit early if the vehicle isn't a car.
Prepare for cross-compatibility with GTA V Enhanced using tupoy-ya's YimLuaAPI.
- Features/PlayerVehicle - Refactored Launch Control: Feture now has two modes (realistic/ridiculous) and performs a lot better than before. - Refactored Fast Jets: No more air drag loss when speed is increased. Jets now handle the same as default, only faster. - Fixed Brake Force Display toggling ABS when the vehicle is moving in reverse. - Fixed tyre smoke color in the Drift Mode feature. - Fixed script entry point.
- Check both repositories instead of legacy only.
| if (script and (type(script) == "table")) then | ||
| if (menu_event and menu_event.Wndproc) then | ||
| if (type(_G["get_game_branch"]) == "function") then | ||
| self.api_version = _G["get_game_branch"]() + 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't rely on your API version table matching the return value of get_game_branch()+1.
I'm thinking doing something like this:
get_game_branch() == game_branch.EnhancedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's a placeholder for now (the function would return a userdata enum not a number) but I put it there to map out what the next step is once we start testing on your new API.
EDIT: wrong wording
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function doesn't exist yet, and it will return an integer, I just think we shouldn't rely on it always being Enums.eAPIVersion-1
- Fix return inside ImGui.Begin without calling ImGui.End
Fixes:
Features/PlayerVehicle
Launch Control: The feature now has two modes (realistic / ridiculous) and performs a lot better than before.Fast Jets: No more air drag loss when speed is increased. Jets now handle the same as default, only faster.Brake Force Displaytoggling ABS when the vehicle is moving in reverse.Drift Modefeature always set to black.Script Globals/Locals:
Pointers:
Scripts/CI: