Skip to content

Fix minor performance issue #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srj0x0 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix minor performance issue #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3971b80
[CoreData] Fix unnecessary fetch request
Oct 9, 2019
9c067d8
Merge pull request #1 from srj0x0/fix/coredata_performace
srj0x0 Oct 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 17 additions & 19 deletions DBClient/CoreData/CoreDataObservable.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,30 +63,28 @@ class CoreDataObservable<T: Stored, U: NSManagedObject>: RequestObservable<T> {
fatalError("CoreDataDBClient can manage only types which conform to CoreDataModelConvertible")
}

observer = closure
fetchedResultsControllerDelegate.observer = { [unowned self] (change: ObservableChange<U>) in
guard case .change(let change) = change else { return }
let mappedInsertions = change.insertions.map { ($0, coreDataModelType.from($1) as! T) }
let mappedModifications = change.modifications.map { ($0, coreDataModelType.from($1) as! T) }
let mappedObjects = change.objects.map { coreDataModelType.from($0) as! T }
let mappedChange: ObservableChange<T>.ModelChange = (
objects: mappedObjects,
deletions: change.deletions,
insertions: mappedInsertions,
modifications: mappedModifications
)
self.observer?(.change(mappedChange))
}
do {
let initial = try fetchedResultsController.managedObjectContext.fetch(fetchRequest)
let mapped = initial.map { coreDataModelType.from($0) as! T }
closure(.initial(mapped))
observer = closure

fetchedResultsControllerDelegate.observer = { [unowned self] (change: ObservableChange<U>) in
guard case .change(let change) = change else { return }
let mappedInsertions = change.insertions.map { ($0, coreDataModelType.from($1) as! T) }
let mappedModifications = change.modifications.map { ($0, coreDataModelType.from($1) as! T) }
let mappedObjects = change.objects.map { coreDataModelType.from($0) as! T }
let mappedChange: ObservableChange<T>.ModelChange = (
objects: mappedObjects,
deletions: change.deletions,
insertions: mappedInsertions,
modifications: mappedModifications
)
self.observer?(.change(mappedChange))
}

try fetchedResultsController.performFetch()
} catch let error {
closure(.error(error))
}
let initial = fetchedResultsController.fetchedObjects ?? []
let mapped = initial.map { coreDataModelType.from($0) as! T }
closure(.initial(mapped))
}

}
Expand Down