Implicitly marking parameter $module as nullable is deprecated, #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the explicit nullable type must be used instead
There was a problem hiding this comment.
Pull request overview
This PR fixes a PHP deprecation warning by adding explicit nullable type declarations to parameters with default null values in the checkVerXoops method. PHP now requires that parameters with a default value of null must be explicitly declared as nullable using the ? syntax.
Key Changes
- Added explicit nullable type hints (
?\XoopsModuleand?string) to thecheckVerXoopsmethod parameters
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * @static | ||
| * @param \XoopsModule|null $module | ||
| * | ||
| * @param null $requiredVer |
There was a problem hiding this comment.
The PHPDoc annotation should be updated to match the new type signature. Change from @param null $requiredVer to @param string|null $requiredVer.
Suggested change
| * @param null $requiredVer | |
| * @param string|null $requiredVer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the explicit nullable type must be used instead