You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mambax7 It must be a dumb question, but what do you expect me to do ? I'm a newbie GitHub contributor :)
I have pull your branch. Do I have to do some tests in particular ? Thx
I have this error when I enable the block Top News
Error: TypeError: XoopsModules/News/NewsStory::getAllPublished(): Argument #4 ($topic) must be of type int, array given, called in /modules/news/blocks/news_top.php on line 401 in file /modules/news/class/NewsStory.php line 222
The problem comes from function getAllPublished in class/NewsStory.phpmambax7@6856d90
The function is declared with an int $topic but it blocks/news_top.php gives an array.
Two solution I have found :
PHP < 8.0 : remove the int before the $topic
PHP >= 8.0 : replace int by int|array
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.