Skip to content

Conversation

@gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Jan 5, 2026

Proposed changes

fix typos

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@coderabbitai
Copy link

coderabbitai bot commented Jan 5, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI review requested due to automatic review settings January 5, 2026 14:45
@gzliudan gzliudan changed the title core/txpool/legacypool: fix typo #27620 core/txpool: fix typos Jan 5, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes various typos and grammatical errors in comments and log messages across the transaction pool codebase. The changes improve code documentation clarity without affecting functionality.

Key Changes

  • Corrected spelling errors (e.g., "contraints" → "constraints")
  • Fixed grammatical issues (e.g., removed duplicate "be", changed "a local ones" → "local ones")
  • Updated log message to be more specific ("Transaction pool" → "Legacy pool")

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
core/txpool/txpool.go Updated comment grammar for the Status function
core/txpool/legacypool/legacypool.go Fixed multiple typos in comments including spelling corrections, removed duplicate words, and updated log message to accurately reflect the pool type

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


// Status returns the known status (unknown/pending/queued) of a transaction
// identified by their hashes.
// identified by its hashes.
Copy link

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment should say "identified by its hash" (singular) rather than "identified by its hashes" (plural), since the function takes a single hash parameter of type common.Hash.

Suggested change
// identified by its hashes.
// identified by its hash.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants