-
Notifications
You must be signed in to change notification settings - Fork 69
core/txpool: fix typos #1915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-upgrade
Are you sure you want to change the base?
core/txpool: fix typos #1915
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dfd8aa0 to
040bca0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes various typos and grammatical errors in comments and log messages across the transaction pool codebase. The changes improve code documentation clarity without affecting functionality.
Key Changes
- Corrected spelling errors (e.g., "contraints" → "constraints")
- Fixed grammatical issues (e.g., removed duplicate "be", changed "a local ones" → "local ones")
- Updated log message to be more specific ("Transaction pool" → "Legacy pool")
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core/txpool/txpool.go | Updated comment grammar for the Status function |
| core/txpool/legacypool/legacypool.go | Fixed multiple typos in comments including spelling corrections, removed duplicate words, and updated log message to accurately reflect the pool type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| // Status returns the known status (unknown/pending/queued) of a transaction | ||
| // identified by their hashes. | ||
| // identified by its hashes. |
Copilot
AI
Jan 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment should say "identified by its hash" (singular) rather than "identified by its hashes" (plural), since the function takes a single hash parameter of type common.Hash.
| // identified by its hashes. | |
| // identified by its hash. |
Proposed changes
fix typos
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that