core/txpool/legacypool: reheap the priced list if london fork not enabled #27481

[gzliudan]

Proposed changes

Ref: ethereum#27481

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)
• Regular KTLO or any of the maintaince work. e.g code style
• CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR refactors the transaction pool architecture to fix issue ethereum#27481 by introducing a reheap mechanism when the London fork is not enabled. The changes split the monolithic transaction pool into a coordinator pattern with a legacy pool subpool implementation.

Key changes:

• Introduced a new SubPool interface to support modular transaction pool implementations
• Split the original TxPool into a coordinator (core/txpool/txpool.go) and a legacy implementation (core/txpool/legacypool/)
• Added reheap logic that triggers when London fork is not enabled (line 1311 in legacypool.go)
• Updated type signatures from types.Transactions to []*types.Transaction throughout the codebase

Reviewed changes

Copilot reviewed 37 out of 37 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
core/txpool/txpool.go	New coordinator implementation managing multiple subpools
core/txpool/subpool.go	Interface definition for transaction pool subpools
core/txpool/legacypool/legacypool.go	Legacy pool implementation with reheap fix
core/txpool/errors.go	Centralized error definitions moved from legacy pool
eth/backend.go	Updated to use new pool structure with legacypool
eth/handler.go	Transaction wrapping for new pool API
miner/worker.go	Type signature fix with capacity hint
internal/ethapi/backend.go	API signature updates for new return types
event/multisub.go	New utility for managing multiple subscriptions

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.