-
Notifications
You must be signed in to change notification settings - Fork 39
Various Improvements #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Various Improvements #181
Conversation
…s had been recieved
fix issue where can't cancel from ban/kick
|
I'll probably be continuing on the UX changes so may be more in future if this gets approved. My next thought is to group up the 'privileges' tab so that for actual 'privileges' it groups them by category as per the menu, and for entities, tools & weapons it groups them by addon. I've used evolve for a very long time, but have had nearly a decades hiatus away from gmod... these are all things that irked me back then but I wasn't really a good enough developer to change them. |
|
I am not sure if @Xandaros is actively looking into this repository. Besides that a couple things I would change:
|
|
Well, it does show up in my notifications, and I do look at everything that shows up, but quite honestly, I don't think I will ever merge this. Might be better to continue in a fork. |
I purposefully included this, the .vscode file is intended to be shared - it makes anyone working on it in the future in the same IDE's (however slim the possibility..) job mildly easier.
Not sure what you're referring to - I removed the one that was immediately stuck out to me as dated when I saw it, but none of the others on the same line stick out to me as being a similar vein.
No - the files were taken from a separate branch in this repo so I didn't really thing about it, but I take your point.
Yeah that's fair, I figured that might be the response. |
I think that's the best option as well. I still maintain my Garry's Mod server using the Xandaros repo of Evolve, and contribute major bug fixes to this repo when needed, but that being said, I actively play sort of half a year on, half a year off these days, so I really need this branch of Evolve to be as stable as possible, with it being the main core of my server. |
Not sure how open to this you (as maintainers) will be - improvements is a subjective term here, and I've touched a number of things for a number of reasons all in this one PR..
Refactoring
Slight refactor to how the category system works - I didn't like the magic strings & id's so I moved all the structure for it to the
evolve.categoryglobal and had everything in the player tab scripts reference that rather than having its own copies.UI/UX tweaks
Plugin changes
Re-introduced Divran's change map/gamemode UI. Not sure why this was lost (among others - my assumption is it was the breaking changes in changing to gmod 13 that wiped them out?) but I wanted it for my server so I found an old copy and polished it up to where it's working. I'm not 100% happy with my implementation of retrieving the maps on demand, but before I made that change there seemed to be a race condition between retrieving the server maps & rendering the tab that if you fell the wrong side of would leave you with an empty map list until re-join. Now if it doesn't have the data it does a relatively naïve polling loop until it gets it.