Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
373fb52
Models and unit tests for LP amendment; TODO: Integ tests are remaini…
ckeshava Sep 8, 2025
aadadbe
update integration test with LoanSet transaction
ckeshava Sep 12, 2025
1db1744
add integ tests for loan-crud operations; update changelog
ckeshava Sep 13, 2025
b062bc3
address first batch of coderabbit AI suggestions
ckeshava Sep 15, 2025
faca6ae
Merge branch 'main' into xls66d
ckeshava Sep 16, 2025
9083a84
fix linter errors
ckeshava Sep 16, 2025
c672015
update Number internal rippled type into str JSON type
ckeshava Sep 17, 2025
029d65c
add unit tests and validation for loan_broker_set txn
ckeshava Sep 18, 2025
1ddf348
loan_set validation and unit tests
ckeshava Sep 18, 2025
4e5cf35
add hex validation for data field
ckeshava Sep 18, 2025
388553d
update tests for LoanSet txn; remove start_date field
ckeshava Sep 18, 2025
31b699e
integ test for Lending Protocol with IOU
ckeshava Sep 18, 2025
e39509f
fix the errors in STIssue codec
ckeshava Sep 19, 2025
88eade6
Merge branch 'updateIssueCodec' into xls66d
ckeshava Sep 19, 2025
3b47b6f
remove debug helper method
ckeshava Sep 22, 2025
9c38b73
integ test for VaultCreate txn with MPToken
ckeshava Sep 23, 2025
f6daf47
feature: allow xrpl-py integ tests to run on XRPL Devnet; This commit…
ckeshava Sep 23, 2025
9f27a07
fix: update the order of the encoding arguments in serialization of I…
ckeshava Sep 23, 2025
d47410a
add SAV integ test with MPToken as Vault asset
ckeshava Sep 24, 2025
bd2f13a
fix: big-endian format to interpret the sequence number in MPTID
ckeshava Sep 24, 2025
fc158fb
Update tests/integration/it_utils.py
ckeshava Sep 24, 2025
2183f0a
address code rabbit suggestions
ckeshava Sep 24, 2025
3162f69
Merge branch 'updateIssueCodec' into xls66d
ckeshava Sep 24, 2025
48bd4e7
integ test: LendingProtocol Vault with MPToken asset
ckeshava Sep 24, 2025
98288b8
Merge branch 'main' into xls66d
ckeshava Sep 29, 2025
9f537b1
Merge branch 'main' into xls66d
ckeshava Dec 8, 2025
394940a
Merge remote-tracking branch 'origin' into xls66d
ckeshava Dec 8, 2025
59b543b
update: PermissionDelegation and LP features have been updated to Sup…
ckeshava Dec 8, 2025
d567c60
Merge branch 'xls66d' of https://github.com/ckeshava/xrpl-py into xls66d
ckeshava Dec 8, 2025
2ba7a5a
feat: Update the design of autofill transaction-fees for the LoanSet …
ckeshava Dec 9, 2025
53bb44c
feat: update autofill method to handle the case where LoanBroker owne…
ckeshava Dec 9, 2025
adc5929
address minor coderabbit suggestions
ckeshava Dec 9, 2025
ffb6608
feat: add support and tests for sign method
ckeshava Dec 9, 2025
9188107
fix: remove moot case in autofilling fees for LoanSet transaction
ckeshava Dec 10, 2025
bc27377
fix: add PermissionDelegationV1_1 amendment into the config file for …
ckeshava Dec 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .ci-config/rippled.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -201,10 +201,11 @@ PermissionedDomains
SingleAssetVault
fixFrozenLPTokenTransfer
fixInvalidTxFlags
PermissionDelegationV1_1
PermissionedDEX
Batch
TokenEscrow
LendingProtocol
PermissionDelegationV1_1

# This section can be used to simulate various FeeSettings scenarios for rippled node in standalone mode
[voting]
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [[Unreleased]]

### Added
- Support for the Lending Protocol (XLS-66d)

## [[4.3.1]] - 2025-11-12

### Added
Expand Down
45 changes: 45 additions & 0 deletions tests/integration/reqs/test_sign.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
from tests.integration.integration_test_case import IntegrationTestCase
from tests.integration.it_utils import fund_wallet_async, test_async_and_sync
from xrpl.asyncio.transaction import autofill_and_sign
from xrpl.models.requests import Sign
from xrpl.models.transactions import LoanSet
from xrpl.wallet import Wallet

_SECRET = "randomsecretkey"
_LOAN_BROKER_ID = "D1B9DFF432B4F56127BE947281A327B656F202FC1530DD6409D771F7C4CA4F4B"
_COUNTERPARTY_ADDRESS = "rnFRDVZUV9GmqoUJ65gkaQnMEiAnCdxb2m"


class TestSign(IntegrationTestCase):
@test_async_and_sync(globals(), ["xrpl.transaction.autofill_and_sign"])
async def test_basic_functionality(self, client):
loan_issuer = Wallet.create()
await fund_wallet_async(loan_issuer)

loan_issuer_signed_txn = await autofill_and_sign(
LoanSet(
account=loan_issuer.address,
loan_broker_id=_LOAN_BROKER_ID,
principal_requested="100",
counterparty=_COUNTERPARTY_ADDRESS,
),
client,
loan_issuer,
)
response = await client.request(
Sign(
transaction=loan_issuer_signed_txn,
signature_target="CounterpartySignature",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sign method will not accept signature_target. It's sign_for that accepts the signature_target.

sign_for is currently not working in rippled as expected and as discussed offline, feel free to log Github but to add support for signature_target in sign_for and submit_multisigned methods.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both sign and submit methods accept the signature_target field in their inputs. Both of them make use of a common parsing method: https://github.com/XRPLF/rippled/blob/4565cc280bf2d91f8f88ef74cc807ece4c91a243/src/xrpld/rpc/detail/RPCCall.cpp#L1000

This is also the reason my PR changes work correctly and pass the integration tests.

Copy link
Collaborator

@Patel-Raj11 Patel-Raj11 Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah my bad, yes, signature_target is required in sign method, when we want to fill in CounterpartySignature (non-multisigning case).

secret=_SECRET,
)
)
self.assertTrue(response.is_successful())
self.assertTrue(response.result["tx_json"]["CounterpartySignature"] is not None)
self.assertTrue(
response.result["tx_json"]["CounterpartySignature"]["SigningPubKey"]
is not None
)
self.assertTrue(
response.result["tx_json"]["CounterpartySignature"]["TxnSignature"]
is not None
)
Loading