Skip to content

improve versionCompare() #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mambax7 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

improve versionCompare() #1595

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c82006
improve versionCompare()
mambax7 Jan 1, 2026
fa9ee69
updates
mambax7 Jan 1, 2026
a87b0f9
simplification
mambax7 Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions htdocs/kernel/module.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,19 +193,29 @@ public function getStatus()
* @param string $operator
* @return boolean The function will return true if the relationship is the one specified by the operator, false otherwise.
*/
public function versionCompare($version1 = '', $version2 = '', $operator = '<')
public function versionCompare($version1 = '', $version2 = '', $operator = '<'): bool
{
$version1 = strtolower($version1);
$version2 = strtolower($version2);
if (false !== strpos($version2, '-stable')) {
$version2 = substr($version2, 0, strpos($version2, '-stable'));
}
if (false !== strpos($version1, '-stable')) {
$version1 = substr($version1, 0, strpos($version1, '-stable'));
$normalize = static function ($ver): string {
$ver = strtolower(trim((string)$ver));
if (($pos = strpos($ver, '-')) !== false) {
$ver = substr($ver, 0, $pos);
}
return trim($ver);
};

$n1 = $normalize($version1);
$n2 = $normalize($version2);

$op = (string)$operator;
$allowed = ['<', '<=', '>', '>=', '==', '!=', '<>'];
if (!in_array($op, $allowed, true)) {
$op = '<';
}
return version_compare($version1, $version2, $operator);

return (bool)version_compare($n1, $n2, $op);
Copy link

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explicit cast to (bool) on line 215 is unnecessary. The version_compare() function already returns a boolean when an operator is provided, so the cast is redundant.

Suggested change
return (bool)version_compare($n1, $n2, $op);
return version_compare($n1, $n2, $op);

Copilot uses AI. Check for mistakes.
}


/**
* Get a link to the modules main page
*
Expand Down