Remove buffering in CraftBlock getNMS and getNMSFluid #471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did as requested.
Honestly, I'd recommend preferably doing a little context analysis of the internal calls before actually merging.
For context, calls involved in
getNMSinclude:net.minecraft.world.level.Level#getBlockStateusingnet.minecraft.world.level.Level#getChunk.net.minecraft.world.level.ServerChunkCache#getChunkFallback.net.minecraft.world.level.ServerChunkCache#syncLoad.If there were a lock,
syncLoadcan become troublesome, but seems like this is not the case on Leaf as it was on Fish.Still, a little bit more research will be required to see if every buffered call to functions in
CraftBlockthat internally callgetNMSare actually safe and free of possible deadlocks.