Log to the Android logd service where appropriate #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spenap
approved these changes
Sep 23, 2025
spenap
left a comment
spenap
left a comment
There was a problem hiding this comment.
LGTM, nice and neat, keeping the previous functionality unless on Android
aperezdc
force-pushed
the
aperezdc/android-logging
branch
from
c739ae8 to
0b04cf4
Compare
Contributor
Author
|
The CI is stuck because GitHub Actions has deprecated (and disabled) the Ubuntu 20.04 images; I have posted PR #139 to make it work again. |
aperezdc
force-pushed
the
aperezdc/android-logging
branch
from
0b04cf4 to
60d1ebf
Compare
Add logging macros and use them. The implementation of the macros uses the Android logging library if available, otherwise they use the standard error output.
aperezdc
force-pushed
the
aperezdc/android-logging
branch
from
60d1ebf to
1f9761f
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logging macros and use them. The implementation of the macros uses the Android logging library if available, otherwise they use the standard error output.