Skip to content

Conversation

@casionone
Copy link

Changes

Dependency Management Optimization

  • Add version properties in root pom.xml for better dependency management
    • spring.boot.admin.version: 2.7.16
    • reactor-netty-http.version: 1.0.39
  • Optimize linkis-et-monitor/pom.xml dependency configuration
    • Use property variables instead of hardcoded versions
    • Add dependency exclusions to resolve conflicts
    • Explicitly declare thymeleaf and reactor-netty-http dependencies

Security Enhancement

  • Add password masking feature in ApplicationConfiguration.java
    • Register AdminServerModule to automatically mask password fields in JSON output
    • Improve security by preventing sensitive information exposure

Decisions Made

  • ✅ Adopted: Dependency management optimization (from WDS)
  • ✅ Adopted: Password masking security feature (from WDS)
  • ❌ Not adopted: Code deletions and refactoring (keep Apache version for stability)
  • ❌ Not adopted: StarRocks monitoring feature deletion (keep all features)
  • ❌ Not adopted: Copyright header changes (maintain Apache license format)

合并变更说明

依赖管理优化

  • 在根 pom.xml 中添加版本属性以优化依赖管理
    • spring.boot.admin.version: 2.7.16
    • reactor-netty-http.version: 1.0.39
  • 优化 linkis-et-monitor/pom.xml 依赖配置
    • 使用属性变量替代硬编码版本
    • 添加依赖排除以解决冲突
    • 显式声明 thymeleaf 和 reactor-netty-http 依赖

安全功能增强

  • 在 ApplicationConfiguration.java 中添加密码脱敏功能
    • 注册 AdminServerModule 自动屏蔽 JSON 输出中的密码字段
    • 提升安全性,防止敏感信息泄露

合并决策

  • ✅ 采纳:依赖管理优化(来自 WDS)
  • ✅ 采纳:密码脱敏安全功能(来自 WDS)
  • ❌ 未采纳:代码删除和重构(保持 Apache 版本稳定性)
  • ❌ 未采纳:StarRocks 监控功能删除(保留所有功能)
  • ❌ 未采纳:版权声明变更(维持 Apache 许可格式)

🤖 Generated with Claude Code

What is the purpose of the change

EngineConn-Core defines the the abstractions and interfaces of the EngineConn core functions.
The Engine Service in Linkis 0.x is refactored, EngineConn will handle the engine connection
and session management.

Related issues/PRs

Related issues: close #590 close #591
Related pr:#591

Brief change log

  • Define the core abstraction and interfaces of the EngineConn Factory;
  • Define the core abstraction and interfaces of Executor Manager.

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

## Changes

### Dependency Management Optimization
- Add version properties in root pom.xml for better dependency management
  - spring.boot.admin.version: 2.7.16
  - reactor-netty-http.version: 1.0.39
- Optimize linkis-et-monitor/pom.xml dependency configuration
  - Use property variables instead of hardcoded versions
  - Add dependency exclusions to resolve conflicts
  - Explicitly declare thymeleaf and reactor-netty-http dependencies

### Security Enhancement
- Add password masking feature in ApplicationConfiguration.java
  - Register AdminServerModule to automatically mask password fields in JSON output
  - Improve security by preventing sensitive information exposure

### Decisions Made
- ✅ Adopted: Dependency management optimization (from WDS)
- ✅ Adopted: Password masking security feature (from WDS)
- ❌ Not adopted: Code deletions and refactoring (keep Apache version for stability)
- ❌ Not adopted: StarRocks monitoring feature deletion (keep all features)
- ❌ Not adopted: Copyright header changes (maintain Apache license format)

## 合并变更说明

### 依赖管理优化
- 在根 pom.xml 中添加版本属性以优化依赖管理
  - spring.boot.admin.version: 2.7.16
  - reactor-netty-http.version: 1.0.39
- 优化 linkis-et-monitor/pom.xml 依赖配置
  - 使用属性变量替代硬编码版本
  - 添加依赖排除以解决冲突
  - 显式声明 thymeleaf 和 reactor-netty-http 依赖

### 安全功能增强
- 在 ApplicationConfiguration.java 中添加密码脱敏功能
  - 注册 AdminServerModule 自动屏蔽 JSON 输出中的密码字段
  - 提升安全性,防止敏感信息泄露

### 合并决策
- ✅ 采纳:依赖管理优化(来自 WDS)
- ✅ 采纳:密码脱敏安全功能(来自 WDS)
- ❌ 未采纳:代码删除和重构(保持 Apache 版本稳定性)
- ❌ 未采纳:StarRocks 监控功能删除(保留所有功能)
- ❌ 未采纳:版权声明变更(维持 Apache 许可格式)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@casionone casionone merged commit 7c8dc86 into apache-master Dec 24, 2025
10 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants