Skip to content

Use generics to improve Swift interop #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikolaykasyanov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use generics to improve Swift interop #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ArrayDiff/VMBArrayDiff.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ typedef NS_ENUM(NSInteger, VMBArrayDiffChangeType) {
@end


extern NSSet *VMBChangesByDiffingArrays(NSArray *left, NSArray *right) __attribute__((overloadable));
extern NSSet *VMBChangesByDiffingArrays(NSArray *left, NSArray *right, __nullable VMBArrayElementComparator comparator) __attribute__((overloadable));
extern NSSet<VMBArrayDiffChange *> *VMBChangesByDiffingArrays(NSArray *left, NSArray *right) __attribute__((overloadable));
extern NSSet<VMBArrayDiffChange *> *VMBChangesByDiffingArrays(NSArray *left, NSArray *right, __nullable VMBArrayElementComparator comparator) __attribute__((overloadable));

NS_ASSUME_NONNULL_END
4 changes: 2 additions & 2 deletions ArrayDiffTests/ArrayDiffTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ - (void)testDiff {
@"comment",
];

NSSet *expectedDiff = [NSSet setWithArray:@[
NSSet<VMBArrayDiffChange *> *expectedDiff = [NSSet setWithArray:@[
[[VMBArrayDiffChange alloc] initWithChangeKind:VMBArrayDiffChangeTypeInsert index:0],
[[VMBArrayDiffChange alloc] initWithChangeKind:VMBArrayDiffChangeTypeDelete index:4],
[[VMBArrayDiffChange alloc] initWithChangeKind:VMBArrayDiffChangeTypeInsert index:2],
]];

NSSet *diff = VMBChangesByDiffingArrays(left, right);
NSSet<VMBArrayDiffChange *> *diff = VMBChangesByDiffingArrays(left, right);

XCTAssertEqualObjects(diff, expectedDiff);
}
Expand Down