Skip to content

Fixed invalid replaceable package #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ankitnaik177 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed invalid replaceable package #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0b205e
Fixed invalid replaceable package
ankitnaik177 Feb 7, 2024
b704d3d
Fixed invalid Modelica URI
ankitnaik177 Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VirtualFCS/Electrochemical/Hydrogen/FuelCellStack.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ model FuelCellStack
outer Modelica.Fluid.System system "System properties";
// Medium models
replaceable package Cathode_Medium = Modelica.Media.Air.MoistAir;
replaceable package Anode_Medium = Modelica.Media.IdealGases.SingleGases.H2 constrainedby Modelica.Media.Interfaces.PartialSimpleIdealGasMedium;
replaceable package Anode_Medium = Modelica.Media.IdealGases.SingleGases.H2 constrainedby Modelica.Media.Interfaces.PartialPureSubstance;
replaceable package Coolant_Medium = Modelica.Media.Water.ConstantPropertyLiquidWater constrainedby Modelica.Media.Interfaces.PartialMedium;
//*** DECLARE PARAMETERS ***//
// Physical parameters
Expand Down
2 changes: 1 addition & 1 deletion VirtualFCS/SubSystems/FuelCellSubSystems.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ model FuelCellSubSystems
outer Modelica.Fluid.System system "System properties";
// Medium decleration
replaceable package Cathode_Medium = Modelica.Media.Air.MoistAir;
replaceable package Anode_Medium = Modelica.Media.IdealGases.SingleGases.H2 constrainedby Modelica.Media.Interfaces.PartialSimpleIdealGasMedium;
replaceable package Anode_Medium = Modelica.Media.IdealGases.SingleGases.H2 constrainedby Modelica.Media.Interfaces.PartialPureSubstance;
replaceable package Coolant_Medium = Modelica.Media.Water.ConstantPropertyLiquidWater constrainedby Modelica.Media.Interfaces.PartialMedium;
// H2 Subsystem Paramters
parameter Real m_FC_subsystems(unit = "kg") = subSystemHydrogen.m_system_H2 + subSystemAir.m_system_air + subSystemCooling.m_system_coolant + batterySystem.m_bat_pack;
Expand Down
2 changes: 1 addition & 1 deletion VirtualFCS/SubSystems/Hydrogen/SubSystemHydrogen.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ model SubSystemHydrogen
// System
outer Modelica.Fluid.System system "System properties";
// Medium declaration
replaceable package Anode_Medium = Modelica.Media.IdealGases.SingleGases.H2(Temperature(start = system.T_start), AbsolutePressure(start = system.p_start)) constrainedby Modelica.Media.Interfaces.PartialSimpleIdealGasMedium;
replaceable package Anode_Medium = Modelica.Media.IdealGases.SingleGases.H2(Temperature(start = system.T_start), AbsolutePressure(start = system.p_start)) constrainedby Modelica.Media.Interfaces.PartialPureSubstance;
// Parameter definition
parameter Real m_system_H2(unit = "kg") = 61 "H2 system mass";
parameter Real V_tank_H2(unit = "m3") = 0.13 "H2 tank volume";
Expand Down
4 changes: 2 additions & 2 deletions VirtualFCS/Vehicles/DriveCycle.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ model DriveCycle
output String file;
algorithm
if v == VirtualFCS.Vehicles.DriveCycle.speed_profile.NEDC then
file := Modelica.Utilities.Files.loadResource("modelica://VirtualFCS.Resources.DataDriveCycles/NEDC.mat");
file := Modelica.Utilities.Files.loadResource("modelica://VirtualFCS/Resources/DataDriveCycles/NEDC.mat");
elseif v == VirtualFCS.Vehicles.DriveCycle.speed_profile.WLTC then
file := Modelica.Utilities.Files.loadResource("modelica://VirtualFCS.Resources.DataDriveCycles/WLTC.mat");
file := Modelica.Utilities.Files.loadResource("modelica://VirtualFCS/Resources/DataDriveCycles/WLTC.mat");
elseif v == VirtualFCS.Vehicles.DriveCycle.speed_profile.custom then
file := path;
end if;
Expand Down