Support console subcommand with alternate federation urls #1429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@tinaboyce (Apologies for pinging you directly) any feedback? Asking because you last merged a PR in this repo. Any response is greatly appreciated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #533
Fixes #905
Hello, following up from PR #557 -- I have successfully tested this change with a GovCloud account. I think the only hold up on #557 was access to a govcloud aws account as it seemed that PR was ready for inclusion (pending rebase).
I'm not sure if I love this approach using region versus setting an explicit federation url but that would be a much more invasive change that I don't feel confident in. Thanks for considering!