-
Notifications
You must be signed in to change notification settings - Fork 8
First set of FL pocket references #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nerdai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, these were all an awesome read IMO. I only found a couple of very minor grammatical/math-text issues.
In addition to those, I think the only other items were:
- Can we have .svg versions of all images (this may handle the dark vs. light themese) automatically for us, depending on how you created these images.
- For the algorithms, and totally up to you (I'm good either way), we could also use markdown blocks as indicated in one of my review comments (and used in the KV Cache pocket ref).
- I think we should change the Summary.md to make the pocket refs that are not available yet to be greyed out.
Other than that, I think these are good to land, and am excited for this FL book to be shared more broadly to our community!
nerdai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Amazing work, @emersodb!
Just please hold off on merging, until I update this to use hosted versions of the assets.
Viky397
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few typo comments. Looks great, thanks for getting these all done David!
[FL] Federated Learning
[FL] Add Basic FL Pocket Ref, Add FedSGD Pocket Ref, Add FedAvg Pocket Ref
Type of Change
Book
Description
Refactored the FL book a bit to make it flow a little more cleanly. Fleshed out the core and horizontal FL chapters. Specifically:
Checklist
{{#author}}or{{#authors}})mdbook watch books/<book-name> --open