Skip to content

Conversation

@emersodb
Copy link
Collaborator

@emersodb emersodb commented May 8, 2025

[FL] Federated Learning

[FL] Add Basic FL Pocket Ref, Add FedSGD Pocket Ref, Add FedAvg Pocket Ref

Type of Change

  • New Pocket Reference
  • Edit to Existing Pocket Reference
  • Other (please describe): Some refactors and reorganizations of the FL book

Book

  • fundamentals
  • nlp
  • cv
  • rl
  • fl
  • responsible_ai

Description

Refactored the FL book a bit to make it flow a little more cleanly. Fleshed out the core and horizontal FL chapters. Specifically:

  1. Adding a Flavors of FL section
  2. Added a clients section
  3. Added a servers section
  4. Added an aggregation strategies section
  5. Added a Horizontal FL section
  6. Added a Vanilla FL section
  7. Added a FedSGD section
  8. Added a FedAvg section

Checklist

  • I have included appropriate contributor tags ({{#author}} or {{#authors}})
  • I have added the reading time preprocessor tag under the title
  • Content is concise and within 7 minutes reading time
  • I have included relevant references and further reading links
  • I have tested locally using mdbook watch books/<book-name> --open
  • Pre-commit hooks pass without errors
  • I have linked to related issues

@emersodb emersodb requested review from Viky397 and nerdai May 8, 2025 20:09
Copy link
Collaborator

@nerdai nerdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, these were all an awesome read IMO. I only found a couple of very minor grammatical/math-text issues.

In addition to those, I think the only other items were:

  1. Can we have .svg versions of all images (this may handle the dark vs. light themese) automatically for us, depending on how you created these images.
  2. For the algorithms, and totally up to you (I'm good either way), we could also use markdown blocks as indicated in one of my review comments (and used in the KV Cache pocket ref).
  3. I think we should change the Summary.md to make the pocket refs that are not available yet to be greyed out.

Other than that, I think these are good to land, and am excited for this FL book to be shared more broadly to our community!

@emersodb emersodb changed the title Checking in WIP of the first set of FL pocket references First set of FL pocket references May 9, 2025
@emersodb emersodb requested review from Viky397 and nerdai May 9, 2025 15:15
Copy link
Collaborator

@nerdai nerdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Amazing work, @emersodb!

Just please hold off on merging, until I update this to use hosted versions of the assets.

Copy link

@Viky397 Viky397 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few typo comments. Looks great, thanks for getting these all done David!

@emersodb emersodb merged commit 708710a into main May 9, 2025
1 check passed
@emersodb emersodb deleted the dbe/first_two_fl_refs branch May 9, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants