directly copies into the root #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NN708
force-pushed
the
fix-space-issues
branch
from
fc09cf0 to
10c88de
Compare
NN708
reviewed
Jan 3, 2026
Member
NN708
left a comment
NN708
left a comment
There was a problem hiding this comment.
We still need to improve dry run handling, as OciExportRootFs() now breaks the future root.
Member
Author
|
Yeah, true, I will look through everything. |
This prevents running out of space if there are too many changes.
taukakao
force-pushed
the
fix-space-issues
branch
from
10c88de to
c657e55
Compare
Member
Author
|
I added the clean up again. It might be useful if files are corrupted for some reason or in some edge cases. I renamed it though, since it would otherwise be a somewhat confusing variable name. |
taukakao
force-pushed
the
fix-space-issues
branch
from
d53a141 to
a20d5ee
Compare
NN708
reviewed
Jan 4, 2026
NN708
requested changes
Jan 5, 2026
taukakao
force-pushed
the
fix-space-issues
branch
from
14cd112 to
f692643
Compare
taukakao
force-pushed
the
fix-space-issues
branch
from
2744089 to
b1b3161
Compare
Member
Author
|
@NN708 I made a release and tested it a bit. Everything seems to be as expected. |
Member
Great work! I'll do some testing later as well. |
NN708
requested changes
Jan 7, 2026
Member
NN708
left a comment
NN708
left a comment
There was a problem hiding this comment.
The core functionality works, but there's an edge case bug when a dry-run is performed on a system where /part-future is empty.
$ pkexec abroot upgrade -d -f -V
(Verbose) NewABSystem: running...:info:
(Verbose) NewABImageFromRoot:info:running...
(Verbose) NewABImageFromRoot:info:found abimage.abr: sha256:04e948d0dd3b003343b69aecbe09c0d6fd7136f8425aedeb83a16f7970c92e1f
(Verbose) NewABRootManager:info:running...
(Verbose) ABRootManager.GetRootPartitions:info:running...
(Verbose) DiskManager.GetPartitionByLabel:info:retrieving partitions
(Verbose) DiskManager.getPartitions:info:running...
(Verbose) DiskManager.getPartitions:info:successfully got partitions for disk
(Verbose) DiskManager.GetPartitionByLabel:info:Partition with UUID120c6001-d845-4f27-9fff-70f6490aebc3has labelvos-a
(Verbose) ABRootManager.IdentifyPartition:info:running...
(Verbose) ABRootManager.IdentifyPartition:info:partition is present
(Verbose) ABRootManager.IsCurrent:info:running...
(Verbose) ABRootManager.IsCurrent:info:partition is current
(Verbose) DiskManager.GetPartitionByLabel:info:retrieving partitions
(Verbose) DiskManager.getPartitions:info:running...
(Verbose) DiskManager.getPartitions:info:successfully got partitions for disk
(Verbose) DiskManager.GetPartitionByLabel:info:Partition with UUID65a05a3a-3bab-41b6-a847-41501ce94d29has labelvos-b
(Verbose) ABRootManager.IdentifyPartition:info:running...
(Verbose) ABRootManager.IdentifyPartition:info:partition is future
(Verbose) ABRootManager.IsCurrent:info:running...
(Verbose) ABRootManager.IsCurrent:info:partition is not current
(Verbose) DiskManager.GetPartitionByLabel:info:retrieving partitions
(Verbose) DiskManager.getPartitions:info:running...
(Verbose) DiskManager.getPartitions:info:successfully got partitions for disk
(Verbose) DiskManager.GetPartitionByLabel:info:Partition with UUIDc708e82d-2911-4e99-8c4f-ebe6710d149fhas labelvos-var
(Verbose) ABRootManager.GetRootPartitions:info:successfully got root partitions
INFO Checking for system updates...
(Verbose) ABSystem.RunOperation:info:startingforce-upgrade
(Verbose) [Stage 0] -------- ABSystemRunOperation
(Verbose) ABSystem.LockOperation:info:lock file created
(Verbose) [Stage 1] -------- ABSystemRunOperation
(Verbose) ABSystem.CheckUpdate:info:running...
(Verbose) OCI.HasUpdate:info:Checking for updates ...
(Verbose) OCI.HasUpdate:info:checking image: ghcr.io/vanilla-arm/desktop:test
(Verbose) OCI.HasUpdate:info:no update available
(Verbose) ABSystem.RunOperation:warn(1.200000):No update available but --force is set. Proceeding...
(Verbose) [Stage 2] -------- ABSystemRunOperation
(Verbose) ABRootManager.GetPresent:info:running...
(Verbose) ABRootManager.GetPresent:info:successfully got present partition
(Verbose) ABRootManager.GetFuture:info:running...
(Verbose) ABRootManager.GetFuture:info:successfully got future partition
(Verbose) ABRootManager.GetBoot:info:running...
(Verbose) DiskManager.GetPartitionByLabel:info:retrieving partitions
(Verbose) DiskManager.getPartitions:info:running...
(Verbose) DiskManager.getPartitions:info:successfully got partitions for disk
(Verbose) DiskManager.GetPartitionByLabel:info:Partition with UUIDe981306e-0840-47ba-83f4-b63a792d3261has labelvos-boot
(Verbose) ABRootManager.GetBoot:info:successfully got boot partition
(Verbose) Partition.Unmount:info:running...
(Verbose) Partition.Unmount:err(0.000000):no mount point
(Verbose) Partition.Unmount:info:running...
(Verbose) Partition.Unmount:err(1.000000):device or resource busy
(Verbose) Partition.Mount:info:running...
(Verbose) Partition.Mount:info:successfully mounted/dev/mapper/vos--root-root--bto/part-future
(Verbose) [Stage 3] -------- ABSystemRunOperation
(Verbose) PackageManager.NewPackageManager:info:running...
(Verbose) PackageManager.GetFinalCmd:info:running...
(Verbose) PackageManager.GetAddPackagesString:info:running...
(Verbose) PackageManager.GetAddPackages:info:running...
(Verbose) PackageManager.getPackages:info:running...
(Verbose) PackageManager.getPackages:info:returning packages
(Verbose) PackageManager.GetAddPackagesString:info:done
(Verbose) PackageManager.GetRemovePackagesString:info:running...
(Verbose) PackageManager.GetRemovePackages:info:running...
(Verbose) PackageManager.getPackages:info:running...
(Verbose) PackageManager.getPackages:info:returning packages
(Verbose) PackageManager.GetRemovePackagesString:info:done
(Verbose) PackageManager.processUpgradePackages:info:no packages to install or remove
(Verbose) NewImageRecipe:info:running...
(Verbose) [Stage 4] -------- ABSystemRunOperation
(Verbose) [Stage 5] -------- ABSystemRunOperation
(Verbose) [Stage 6] -------- ABSystemRunOperation
(Verbose) NewChroot:info:running...
(Verbose) Chroot.Execute:info:running...
(Verbose) Chroot.Execute:info:running command:mount --bind / /
chroot: failed to run command ‘/bin/sh’: No such file or directory
(Verbose) Chroot.Execute:err(0.000000):exit status 127
(Verbose) NewChroot:err(1.000000):exit status 127
(Verbose) ABSystem.RunOperation:err(7.020000):exit status 127
(Verbose) Partition.Unmount:info:running...
(Verbose) Partition.Unmount:info:successfully unmounted/part-future
(Verbose) ABSystem.UnlockOperation:info:lock file removed
ERROR exit status 127This makes it possible to cancel the operation after downloading.
taukakao
force-pushed
the
fix-space-issues
branch
from
b1b3161 to
b0c517f
Compare
Member
Author
|
Makes sense, we can't run chroot in dryrun then. I made the change. |
NN708
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents running out of space if there are too many changes.
It also improves compatibility with non-CoW filesystems since it doesn't rely on reflink clones anymore.
The downside is that the time window in which the future root is unusable will be longer.
Though since we always have the current root, this should not really be a problem.