Skip to content

Conversation

@stephenwf
Copy link
Contributor

@stephenwf stephenwf commented Sep 28, 2020

Goal of this PR

  • Add general support for imported modules into the UV for easier integration pre-webpack
  • Update Manifesto to version 4
  • Update Manifold to version 2

This will allow UV v3 to continue to get updates with additional support for Presentation 3 fields and bug fixes without maintaining more than one major version of the 2 libraries. This work will lessen the impact of https://github.com/UniversalViewer/universalviewer/tree/webpack and provides an incremental change to v3.

I've split the update into 5 commits.

  • The first is supporting changes which adds some work-arounds for requireJS and a pattern for allowing node_module imports to be loaded "correctly" by requirejs or as correctly as is possible. This will be supplanted by the switch to webpack.
  • The second is a change to the typescript config to open up node-style imports e.g. import { MetadataComponent } from '@iiif/iiif-metadata-component'.
  • The 3rd is a big update of all of the typescript files to transition from the namespace imports to module imports
  • The 4th commit applies some changes to the dependencies in the extensions
  • This commit is ONLY generated files

Changes in loading

  • The external IIIF components are lazy loaded, like the other modules
  • You can now import an node dependency - so long as you add the module to the config.js and also apply the pattern from app.ts. It is not ideal, but a pattern that can tide us over until webpack
  • There are 3 more files in the lib. If anyone relies on the contents of this folder statically, they will need to update that list.

Related PRs

@demiankatz
Copy link
Contributor

This sounds reasonable to me, though I have not yet taken the time to closely review or test (it's VuFind Summit this week, so my calendar is packed). @edsilv, if you need my backup on this, please let me know and I'll schedule some time (and/or ask @Geoffsc to take a look).

"@iiif/iiif-metadata-component": "1.1.13",
"@iiif/iiif-gallery-component": "1.1.19",
"@iiif/iiif-metadata-component": "1.1.19",
"@iiif/iiif-tree-component": "1.1.16",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To come back to: Tree component is now at 2.0.3 with the correct import

@edsilv edsilv merged commit b2a2569 into master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants