Skip to content

Fix 2D indexing for gridpec #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cvanelteren merged 4 commits into from
Dec 17, 2025
Merged

Fix 2D indexing for gridpec #435

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66dd55f
the fix
cvanelteren Dec 17, 2025
210225e
Merge branch 'main' into fix-slicing-grid
cvanelteren Dec 17, 2025
03eaf37
add type checks
cvanelteren Dec 17, 2025
5c56b4d
replace with np equivalent
cvanelteren Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions ultraplot/gridspec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,24 @@
import itertools
import re
from collections.abc import MutableSequence
from functools import wraps
from numbers import Integral
from typing import List, Optional, Tuple, Union

import matplotlib.axes as maxes
import matplotlib.gridspec as mgridspec
import matplotlib.transforms as mtransforms
import numpy as np
from typing import List, Optional, Union, Tuple
from functools import wraps

from . import axes as paxes
from .config import rc
from .internals import ic # noqa: F401
from .internals import _not_none, docstring, warnings
from .internals import (
_not_none,
docstring,
ic, # noqa: F401
warnings,
)
from .utils import _fontsize_to_pt, units
from .internals import warnings

__all__ = ["GridSpec", "SubplotGrid"]

Expand Down Expand Up @@ -1650,7 +1653,10 @@ def __getitem__(self, key):
)
new_key.append(encoded_keyi)
xs, ys = new_key
objs = grid[xs, ys]
if np.iterable(xs) and np.iterable(ys):
objs = grid[np.ix_(xs, ys)]
else:
objs = grid[xs, ys]
if hasattr(objs, "flat"):
objs = [obj for obj in objs.flat if obj is not None]
elif not isinstance(objs, list):
Expand Down