-
Notifications
You must be signed in to change notification settings - Fork 185
Fix Ubuntu 24.04 CPU XML config #2255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the XML configuration file reference for Ubuntu 24.04 (Noble Numbat) from the outdated Focal Fossa template to a new dedicated configuration file and adds the new XML template.
- Updates the
xmlfield fromfocal_fossa-amd64.xmltonoble-amd64.xmlfor the ubuntu_noble ISO configuration - Adds a new libvirt/KVM XML template file specifically for Ubuntu 24.04
- The new XML includes CPU configuration settings with host-model passthrough
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/Ravada.pm | Updates the XML file reference for Ubuntu 24.04 from the Focal Fossa template to the new Noble-specific template |
| etc/xml/noble-amd64.xml | Adds new libvirt/KVM domain XML configuration template for Ubuntu 24.04 with CPU topology settings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name => 'Ubuntu 24.04 Noble Nombat' | ||
| ,description => 'Ubuntu 24.04 Noble Nombat 64 bits' |
Copilot
AI
Nov 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling error: "Nombat" should be "Numbat". Ubuntu 24.04's codename is "Noble Numbat", not "Noble Nombat".
| name => 'Ubuntu 24.04 Noble Nombat' | |
| ,description => 'Ubuntu 24.04 Noble Nombat 64 bits' | |
| name => 'Ubuntu 24.04 Noble Numbat' | |
| ,description => 'Ubuntu 24.04 Noble Numbat 64 bits' |
etc/xml/noble-amd64.xml
Outdated
| <vmport state='off'/> | ||
| </features> | ||
| <cpu mode='host-model' check='none'> | ||
| <topology sockets='1' cores='2' threads='2'/> |
Copilot
AI
Nov 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CPU configuration mismatch: vcpu is set to 1, but the CPU topology specifies 4 virtual CPUs (1 socket × 2 cores × 2 threads = 4). Either change vcpu to 4 or adjust the topology to match 1 vCPU (e.g., <topology sockets='1' cores='1' threads='1'/>). For a generic configuration, it's typically better to set vcpu to 1 and remove the topology element, allowing it to be configured dynamically.
| <topology sockets='1' cores='2' threads='2'/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wenqiange Copilot warned vcpu is set to 1, but in cpu topology is 1-2-2. I think the vcpu line can be removed. Please try and see if it works.
No description provided.