Skip to content

Conversation

@wenqiange
Copy link
Collaborator

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the XML configuration file reference for Ubuntu 24.04 (Noble Numbat) from the outdated Focal Fossa template to a new dedicated configuration file and adds the new XML template.

  • Updates the xml field from focal_fossa-amd64.xml to noble-amd64.xml for the ubuntu_noble ISO configuration
  • Adds a new libvirt/KVM XML template file specifically for Ubuntu 24.04
  • The new XML includes CPU configuration settings with host-model passthrough

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
lib/Ravada.pm Updates the XML file reference for Ubuntu 24.04 from the Focal Fossa template to the new Noble-specific template
etc/xml/noble-amd64.xml Adds new libvirt/KVM domain XML configuration template for Ubuntu 24.04 with CPU topology settings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 460 to 461
name => 'Ubuntu 24.04 Noble Nombat'
,description => 'Ubuntu 24.04 Noble Nombat 64 bits'
Copy link

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "Nombat" should be "Numbat". Ubuntu 24.04's codename is "Noble Numbat", not "Noble Nombat".

Suggested change
name => 'Ubuntu 24.04 Noble Nombat'
,description => 'Ubuntu 24.04 Noble Nombat 64 bits'
name => 'Ubuntu 24.04 Noble Numbat'
,description => 'Ubuntu 24.04 Noble Numbat 64 bits'

Copilot uses AI. Check for mistakes.
<vmport state='off'/>
</features>
<cpu mode='host-model' check='none'>
<topology sockets='1' cores='2' threads='2'/>
Copy link

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CPU configuration mismatch: vcpu is set to 1, but the CPU topology specifies 4 virtual CPUs (1 socket × 2 cores × 2 threads = 4). Either change vcpu to 4 or adjust the topology to match 1 vCPU (e.g., <topology sockets='1' cores='1' threads='1'/>). For a generic configuration, it's typically better to set vcpu to 1 and remove the topology element, allowing it to be configured dynamically.

Suggested change
<topology sockets='1' cores='2' threads='2'/>

Copilot uses AI. Check for mistakes.
Copy link
Member

@frankiejol frankiejol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wenqiange Copilot warned vcpu is set to 1, but in cpu topology is 1-2-2. I think the vcpu line can be removed. Please try and see if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants