Some temperature dependency implementation for binary fitting #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wband
reviewed
Sep 25, 2024
| break # Found the phase, no need to check further keys | ||
|
|
||
| # Convert lists to dictionaries for kwell, cmin, and fmin | ||
| kwell_dict = dict(kwell_list) |
There was a problem hiding this comment.
These should be attributes of the object. Right now they aren't stored or returned.
wband
reviewed
Sep 25, 2024
| D_dict = {T: 0.5 * kwell_dict[T] * cmin_dict[T] * cmin_dict[T] + fmin_dict[T] for T in kwell_dict.keys()} | ||
|
|
||
| # Fit and plot A, B, D | ||
| self.fit_and_plot(A_dict, phase_name, 'A', 'blue') |
There was a problem hiding this comment.
Let's keep plotting out of this file. This stuff can go in a separate example like this: https://github.com/wband/AMMBER_python/blob/examples/examples/example_AlCu_eutectic.py
I think we were waiting to merge that in until we had permission to republish the TDB files or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.