-
Notifications
You must be signed in to change notification settings - Fork 4
Fix/gsteenkamp custom bond #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
| "ID is managedRequestId, ie. the hash of requester, identifier, ancillaryData" | ||
| id: ID! | ||
|
|
||
| managedRequestId: String! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this, isn't it the same as it for CustomLiveness?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh true, we can probably remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
3bd6928 to
e1f62f5
Compare
closes UMA-2945
Fix Custom Bond Currency Matching Logic
Problem
Custom bonds were not being properly matched to price requests based on currency. The system was incorrectly applying custom bonds regardless of currency mismatch.
Solution
Key Changes
handleCustomBondSetto usecreateCustomBondIdFromEventfor entity ID generationgetCustomBondto only find custom bonds with matching currenciesTechnical Details
Custom bond IDs are now generated by hashing:
requester + identifier + ancillaryData + currency. This ensures that custom bonds set for different currencies have different IDs, even with identical other parameters, preventing cross-currency bond application.