set custom liveness and bond at propose time #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
md0x
reviewed
Sep 10, 2025
| log.info("State: {}", [priceRequestEntity.state!]); | ||
| }); | ||
|
|
||
| test("Custom bond and liveness are applied to RequestPrice entity at PROPOSE time", () => { |
Contributor
There was a problem hiding this comment.
Should we also test custom bond updates?
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Reinis-FRP
approved these changes
Sep 11, 2025
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Per the MOOv2 contract, admin may set
customLivenessandcustomBondafter request time.Update the request Price entity at propose time.