Skip to content

Conversation

@gsteenkamp89
Copy link
Contributor

@gsteenkamp89 gsteenkamp89 commented Sep 5, 2025

Work Done

  1. If customBond or customLiveness is set before a request is made, we can load these values at request time and add them to the priceRequest entity for convenient querying
  2. Add testing framework, CI workflow

Notes on CI & tests
-The CI job is scoped to the following packages

  1. OOv1
  2. OOv2
  3. OOv3
  4. MOOv2
  5. Skinny OO
  6. Voting V2
  • The test coverage is actually pretty minimal. For now we're only testing some handlers for the managed OO.
  • The CI workflow containsa build step and a test step, that runs on PRs to master. Each package now has a prepare-ci script that runs codegen && build. So The entire monorepo must build and tests must pass for the job to succeed.

TODOs

  • Deploy
  • Test

Copy link
Member

@mrice32 mrice32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry approved this mistakenly. Meant to approve the other PR :)

@gsteenkamp89 gsteenkamp89 force-pushed the feat/custom-liveness-bond branch from 9c86161 to 1d0dea5 Compare September 8, 2025 22:04
@gsteenkamp89 gsteenkamp89 requested a review from mrice32 September 8, 2025 22:17
@gsteenkamp89 gsteenkamp89 force-pushed the feat/custom-liveness-bond branch 2 times, most recently from 59adb8c to fba6a2d Compare September 9, 2025 16:24
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
@gsteenkamp89 gsteenkamp89 force-pushed the feat/custom-liveness-bond branch from fba6a2d to 9dc51d1 Compare September 9, 2025 16:29
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
@gsteenkamp89 gsteenkamp89 merged commit c2380b6 into master Sep 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants