feat(bot-oo): detect nonce backlog and attempt self-tx cancellation #4915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
md0x
requested review from
Reinis-FRP,
chrismaree and
mrice32
as code owners
Reinis-FRP
reviewed
Jan 6, 2026
|
|
||
| const parsePositiveInt = (value: string | undefined, defaultValue: number): number => { | ||
| const parsed = Number(value); | ||
| return Number.isFinite(parsed) && parsed > 0 ? Math.floor(parsed) : defaultValue; |
Contributor
There was a problem hiding this comment.
Might be more predictable if we only allow positive integers in the value (unless undefined) and throw if the value does not parse correctly. I would rather expect to use default value only when value was not passed in env
Comment on lines
+23
to
+24
| replacementBumpNumerator: parsePositiveInt(env.NONCE_REPLACEMENT_BUMP_NUMERATOR, DEFAULT_REPLACEMENT_BUMP_NUMERATOR), | ||
| replacementBumpDenominator: parsePositiveInt( |
Contributor
There was a problem hiding this comment.
there is no check that resulting numerator is larger than denominator that one would normally expect with fee bumps. Also, do we really need such high precision here? It might be simpler to have single integer percentage points bump (e.g. value of "20" would bump the fee up by 20%)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Adds a guardrail to the OO bot to detect nonce backlogs before running settlements.
If pending > latest, the bot skips settlements and attempts to clear the backlog by submitting a 0-value self-tx at nonce = latest. If it succeeds, it exits cleanly; if all attempts fail, it logs an error and exits early.
Why:
Submitting new settlements while txs are stuck can compound nonce issues. This makes the bot fail-safe, either self-healing or exiting loudly to avoid further damage.